1074837 - The commits shown in the "Revision URL List" popup are inverted

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ryan VanderMeulen [:RyanVM]]

They need to be in the opposite order to match how the post-commit hook prints them out (and making the list way more useful from a copy/paste into a bug standpoint).

Comment 1

[Ed Morley [:emorley]]

Need to just invert the order here:

https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/directives/resultsets.js#L11

            var openRevisions = function() {
                var interpolator = thCloneHtml.get('revisionUrlClone').interpolator;
                var htmlStr = '';
                _.forEach(scope.resultset.revisions, function(revision) {
                    htmlStr = htmlStr + interpolator(
                        {repoUrl: scope.currentRepo.url, revision: revision}
                    );
                });
                var el = $compile(interpolator(scope))(scope, function(el, scope) {
                    var wnd = window.open(
                        '',
                        scope.repoName,
                        "outerHeight=250,outerWidth=500,toolbar=no,location=no,menubar=no"
                    );
                    wnd.document.write(htmlStr);
                });
            };

(Tweaking summary to differentiate from the list of revisions in the main UI)

Comment 2

[Ed Morley [:emorley]]

Attachment: Display "Revision URL List" commits in old-to-new order

This displays reverses the order of the commits, so they are in old-to-new order, to match TBPL:
https://hg.mozilla.org/webtools/tbpl/file/74a1a15f6593/js/UserInterface.js#l1120

I'm up for suggestions as to how the indentation should be changed - I'm not overly happy with the few ways I tried.

Also we might want a comment - let me know :-)

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/487b7fa7803307fdafadbafa33e3dc6cd308335f
Bug 1074837 - Display "Revision URL List" commits in old-to-new order

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f133ced0c5b9736195f651e7d66d0e79439e61de
Bug 1074837 - Display "Revision URL List" commits in old-to-new order