1074846 - Displaying Flags in search results does not show requestee if one is set

Status: NEW

(Bugzilla :: Query/Bug List, enhancement)

Description

[Mike Hoye [:mhoye]]

As it says on the tin, I'm wondering if on the list of columns that BMO displays, we can add "person who is currently needinfo'ed on this bug". 

Thanks.

Comment 1

[David Lawrence [:dkl]]

If you mean from a list of bug in a search result, you can add the "Flags" column to the list of columns which will show the needinfo? flag if set for a bug. But I do realize now that the requestee is not included in the column value so that would be a good feature to add.

Also this would then be an upstream issue as the current version upstream also does not show the requestee. Needinfo behind the scenes is a normal flag so this is not a needinfo specific issue, rather a flag specific issue.

dkl

Comment 2

[Mike Hoye [:mhoye]]

Yup, that's precisely what I'm looking for. What's next? Close this here, file it upstream?

Comment 3

[David Lawrence [:dkl]]

(In reply to Mike Hoye [:mhoye] from comment #2)
> Yup, that's precisely what I'm looking for. What's next? Close this here,
> file it upstream?

This bug is an upstream bug atm. I have added it to my short-list of next tasks unless someone else gets to it first.

dkl

Comment 4

[Albert Ting]

Attachment: requestee.txt

I know this patch won't work, but thought I take an iterative approach to try to get the ball rolling.

This patch correctly creates the initial query.  But then Search.pm does a followup query that has empty values in the IN list that confuses SQL, as noted below.  Any ideas?

SELECT DISTINCT bugs.bug_id, MIN(group_control_map.membercontrol) FROM bugs INNER JOIN bug_group_map ON bugs.bug_id = bug_group_map.bug_id LEFT JOIN group_control_map ON group_control_map.product_id = bugs.product_id AND group_control_map.group_id = bug_group_map.group_id WHERE bugs.bug_id IN (,7553,7585,7613,7800,,8000,.....) GROUP BY bugs.bug_id"

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 8748909 [details] [diff] [review]
requestee.txt

Unfortunately I cannot get to this right now. Maybe Dylan can look at this and provide feedback before me.