1074885 - TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-content-script.test valueOf | valueOf is missing

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Tomislav Jovanovic :zombie]

looks something with xray wrappers changed again..

https://tbpl.mozilla.org/php/getParsedLog.php?id=49186096&tree=Jetpack


possible candidates:

Bug 787070 - Expandos on the xray of DOM prototypes should have effect on xrays of DOM nodes
Bug 1067501 - Make stringification of DOM Xrays use Object.prototype.toString

Comment 1

[Tomislav Jovanovic :zombie]

also bug 787013 is mentioned in the test comment, so maybe this was on purpose? 

Bobby, is this test simply not relevant anymore, and should be disabled, or is this a regression?

Comment 2

[Bobby Holley (:bholley)]

Yes, the behavior there has now been fixed. I'm not sure why the test is specifically checking that it isn't fixed. Gabor?

Comment 3

[Gabor Krizsanits (INACTIVE)]

(In reply to Bobby Holley (:bholley) from comment #2)
> Yes, the behavior there has now been fixed. I'm not sure why the test is
> specifically checking that it isn't fixed. Gabor?

I think this test is from back in the days when we used to have content-proxy layer to hack around xray wrapper oddities. Alex had a bunch of tests to warn about any changes around xrays so he does not have to spend hours on tracking down why are things broken. Right now I think this test is just a left over and should be simply disabled.

Comment 4

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1668

ok, i also resolved bug 787013 then..

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f7a7dbbe5bc958ed16fbb34d80d8ca0ac121e0f5
bug 1074885 - remove old wrapper test

https://github.com/mozilla/addon-sdk/commit/2718493c2de4319c139b63f3b9ed5ef951be40a0
Merge pull request #1668 from zombie/1074885-remove-old-test

bug 1074885 - remove old wrapper test, r=@jsantell