1074905 - Tweak result set datetime format displayed in UI

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Treeherder currently uses:
Sep 30, 2014 2:03:13 PM

TBPL used:
Mon Sep 29 17:16:48 2014

Some thoughts:
* We should use 24 hour clock like TBPL, since it's quicker to grok & means we can save characters by dropping the AM/PM
* The year is redundant, we could remove it to save space (and perhaps ensure it's visible on a the tooltip?)
* Do we need seconds?
* I wonder if relative times might be useful? (eg "10 minutes ago", with the actual timestamp on the tooltip)

Comment 1

[Jonathan French (:jfrench)]

Relative sounds cool, I guess it's all a question of whether you need to:

- potentially copy/paste the date information
- have more specificity rather than just 'a year ago' when quickly looking at old resultsets
- see the timestamp immediately rather than wait for the hover.

Also in relative time, if the timestamp replaced the existing tooltip content 'open this resultset in new tab' I would guess we would need the added UI of a new icon to open it? Since the tooltip would now be a timestamp string, and the open functionality would not be discoverable. That would also consume more space.

I'm not a sheriff though, just some thoughts.

Related data point, in relative mode (eg. 'a year ago', '11 hours ago') a Github tooltips generally uses the existing timestamp format that Treeherder currently uses, with an added comma separator, no seconds, and a trailing timezone:

Sep 30, 2014, 2:03 PM EDT


And a related data point, Treeherder's full structured log format recently landed, is:

Tue Sep 30 2014 14:03:13 GMT-0400 (Eastern Daylight Time)

Comment 3

[Jonathan French (:jfrench)]

I've tried this change locally, where currently we have in production:

Nov 5, 2014 3:05:41 PM - [e-mail]

We would now have:

Wed Nov 5, 15:05:41- [e-mail]

I stuck a comma in there, it seems to read a bit better on the platform. Similarly I left seconds in, to be consistent with Logviewer. So when you look at both, they'll both present hours, minutes, and seconds.

The tooltip is "open resultset in new tab", which seems to still make sense to me, since that is what it does when you click on the link. If we want YYYY I pose we'd add it in above like Logviewer, or just leave it out entirely. Whatever you guys think is best there.

Comment 4

[Jonathan French (:jfrench)]

I've also got the relative times working locally, using moment.js, if that is preferred.

eg.
12 minutes ago - [e-mail]
4 hours ago - [e-mail]

You'd lose the specificity of the date, unless you looked at the head push on hg.mozilla.org. Since the tooltip needs to cue the user that the link opens the resultset in a new page/tab.

I guess you could overload the tooltip with several things, but that might kind of look chaotic. We could put this relative time in grey, beside the actual linked time if it benefits anyone.

eg.
Wed Nov 5, 15:05:41 (7 hours ago) - [e-mail]

Comment 5

[Jonathan French (:jfrench)]

I checked in w/Ryan in channel and his take was the relative (x hours ago) addition didn't add much value since it already displays in local time. I'm open to integrating it though if others still feel its useful.

Comment 6

[Jonathan French (:jfrench)]

Attachment: resultsetDateChoices

Actually, a picture of each is better than describing it :) Here's are the new choices for reference.

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8518338 [details]
resultsetDateChoices

I think the one without the relative time stamp makes most sense from a value-per-pixel point of view :-)

Comment 8

[Jonathan French (:jfrench)]

Ok thanks Ed, assigning and I'll put up a PR.

Comment 9

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#263

Please see the above PR for review and status.

Comment 10

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/e95f5a917c9693035e0bc996df2273f5edd0cac5
Bug 1074905 - Adjust result set datetime format displayed in UI

https://github.com/mozilla/treeherder-ui/commit/59c908f39d712ae6b3b6d12e8f9a1a070e0f55f0
Merge pull request #263 from tojonmz/resultset-datetime

Bug 1074905 - Adjust result set datetime format displayed in UI

Comment 11

[William Lachance (:wlach)]

Comment on attachment 8518660 [details] [review]
treeherder-ui-PR#263

Looks great, thank you!

Comment 12

[Jonathan French (:jfrench)]

Verified fixed and working correctly on stage.

Comment 13

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5dff4226b9fcdba24dc5267fb8d96c049043ee40
Bug 1074905 - Adjust result set datetime format displayed in UI

https://github.com/mozilla/treeherder/commit/25c198efa6a551f3688bd2d5cfd5bd1c849eb4ea
Merge pull request #263 from tojonmz/resultset-datetime

Bug 1074905 - Adjust result set datetime format displayed in UI