1074909 - [Browser Start Page] History results with no favicon have broken image

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Eric Pang [:epang] UX]

Attachment: 2014-09-30-17-05-00.png

Currently when there's no favicon a broken image is shown.  A default image should be used when one is not available.

Comment 1

[Eric Pang [:epang] UX]

Dale, can you help with this?  I'm thinking a simple globe would best best (like Fennec).  I can get the assets ready if you can let me know the sizes that will be needed.  Let me know, thanks!

Comment 2

[Dale Harvey (:daleharvey)]

Yup, those are only ever shown at 16x16, we just showed a dashed border previously, gimme the assets and ill get it fixed, cheers

Comment 3

[Dale Harvey (:daleharvey)]

Needinfoing to keep track of the required assets

Comment 4

[Eric Pang [:epang] UX]

Attachment: no favicon icons

Hey Dale, a dashed border works for me.  I created the assets, but left some padding around them.  For example the 16x16 one is 30x30.

Let me know if these assets will be okay, thanks!

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/24711

So this is actually a regression from our fallback to favicon.ico, it will also be cleaned up by the icon service but a simple fallback for now

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8498959 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24711

I feel like it would be better to not use a fake spacer and instead remove the image and fixup the CSS. I'm fine if you want to land this instead though.

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/commit/03b59751d60912dce55198968c988abc00c2c15b

Carrying r+ as its similiar, but removed the spacer gif and only show the icon on load now

Comment 8

[Dale Harvey (:daleharvey)]

Fixed in https://github.com/mozilla-b2g/gaia/commit/03b59751d60912dce55198968c988abc00c2c15b

Comment 9

[Ed Morley [:emorley]]

Reverted for timeouts in search/test/unit/providers/contacts_test.js:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=584881&repo=b2g-inbound
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=585072&repo=b2g-inbound

https://github.com/mozilla-b2g/gaia/commit/f5b5420056ddbfcd76a2ff60c97682f59d2605c9

Comment 10

[Dale Harvey (:daleharvey)]

Ugh apologies, the contacts search is currently disabled so didnt figure it would break tests, fixed and repushed to try, will wait for green this time.

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=39492e71d910

Comment 11

[Dale Harvey (:daleharvey)]

Try run was green except one unrelated Gip test that passed on rerun

https://github.com/mozilla-b2g/gaia/commit/6efba330470a888f20f05fc2afd7f7e7978f31e6