1075144 - LSan mochitest test harness code does not parse (anonymous namespace) correctly

Status: NEW

(Testing :: Mochitest, task, P3)

Description

[David Teller [:Yoric] - still alive but not very active]

See https://treeherder.mozilla.org/ui/logviewer.html#?job_id=783860&repo=fx-team
« TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at PR_NewCondVar, PR_Sleep, mozilla::, _pt_root »

No clue what `mozilla::` or `_pt_root` refer to.

Comment 1

[Andrew McCreight [:mccr8]]

This is the stack trace:

==1860==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 64 byte(s) in 1 object(s) allocated from:
#0 0x7f5deaf7a4f1 in malloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:74
#1 0x7f5de73830b3 in PR_NewCondVar /builds/slave/fx-team-l64-asan-0000000000000/build/nsprpub/pr/src/pthreads/ptsynch.c:321
#2 0x7f5de7393eae in PR_Sleep /builds/slave/fx-team-l64-asan-0000000000000/build/nsprpub/pr/src/pthreads/ptthread.c:826
#3 0x7f5dd6bba369 in mozilla::(anonymous namespace)::RunWatchdog(void*) /builds/slave/fx-team-l64-asan-0000000000000/build/toolkit/components/terminator/nsTerminator.cpp:141
#4 0x7f5de7396405 in _pt_root /builds/slave/fx-team-l64-asan-0000000000000/build/nsprpub/pr/src/pthreads/ptthread.c:212

The (anonymous namespace) is confusing the parser, which is why we have the mozilla::.

_pt_root is just a weird NSPR function and that is working as intended. ;)

Comment 2

[Andrew McCreight [:mccr8]]

It looks like the open paren will still confuse stackFrameRegExp, but that's probably okay. I haven't seen a ton of complaints about this issue;