Closed
Bug 1075211
Opened 11 years ago
Closed 11 years ago
Remove the self hack from content/newtab/updater.js
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
Details
Attachments
(1 file)
|
1.74 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
If you look at https://github.com/mozilla/gecko-dev/blob/master/browser/base/content/newtab/updater.js then you will see a large number of `var self = this;` hacks that can all be easily avoided by using arrow functions.
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → evold
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Summary: Remove the self hacks from content/newtab/updater.js → Remove the self hack from content/newtab/updater.js
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8497832 -
Flags: review?(ttaubert)
|
|
Assignee | |
Updated•11 years ago
|
Version: 32 Branch → Trunk
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8497832 [details] [diff] [review]
1075211.patch
Review of attachment 8497832 [details] [diff] [review]:
-----------------------------------------------------------------
Cool, thanks!
Attachment #8497832 -
Flags: review?(ttaubert) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•