1075244 - [Lockscreen] When user changes the loc of the device and locks the screen, the time on the lock screen will go lower each time.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[[:SalvadorR]]

Attachment: logcat_20140930_1633.txt

Description:
When user changes the language of the device and locks the screen. the timer in the lock screen will go lower every each time the language changes and the device is locked.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140930040206
2) Navigate to settings and change the language of the device
3) After changing the langauge, press the power button
4) Press the power button again to navigate to the lock screen
5) Observe the placement of the timer in the lockscreen

Actual:
The Time in the lockscreen will be placed lower each time the language changes and device locks
  
Expected: 
The placement of the time in the lockscreen will not change when changing languages
  
Flame 2.2 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140930040206
Gaia: 77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de
Gecko: 7c24470b6b3a
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
  
Notes: When the time gets low enough to overlap the lock bar, the user will no longer be able to unlock their phone
  
Repro frequency: 3/3
See attached: Screenshot, Logcat

Comment 1

[[:SalvadorR]]

Attachment: Time lower.png

Comment 2

[[:SalvadorR]]

This issue does not occur on Flame 2.0 KK (319mb) and Flame 2.1 KK (319mb)

Expected: 
The placement of the time in the lockscreen will not change when changing languages

Flame 2.0 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.0
BuildID: 20140930000204
Gaia: 5c2303ec4e367da060aa1b807d541a6549b3d72a
Gecko: 38a496c50d98
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 2.1 KitKat Base (319mb)(Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20140930000203
Gaia: a00d102abfe8ae15c4fd14771efa2335c6d3b8d9
Gecko: cde28bd9a285
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Nominating 2.2? since this is a regression and can lead to the user not being able to unlock their phone.

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1057198 seems to be the cause for this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20140928200800
Gaia: 931d547dbd2f4664b6a3c1ff5e4244bca52f96ad
Gecko: a66e8e91480a
Version: 35.0a1 (2.2) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20140928234300
Gaia: 369e3579af3f41fcb9c9c3508d6358ff7b797b64
Gecko: 1085a98ece6c
Version: 35.0a1 (2.2) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Last Working gaia / First Broken gecko - Issue does NOT occcur
Gaia: 931d547dbd2f4664b6a3c1ff5e4244bca52f96ad
Gecko: 1085a98ece6c

First Broken gaia / Last Working gekko - Issue DOES occur
Gaia: 369e3579af3f41fcb9c9c3508d6358ff7b797b64
Gecko: a66e8e91480a

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/931d547dbd2f4664b6a3c1ff5e4244bca52f96ad...369e3579af3f41fcb9c9c3508d6358ff7b797b64

Comment 5

[Joshua Mitchell (Inactive)]

Caused by Bug 1057198? Can you investigate Greg?

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8500301 [details] [review]
Patch

One more reason for us to work on lockscreen.js before moving on :)

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Since the only failed test on Gaia-Try is intermittent and irrelevant, I land this patch.

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/217f6e7b4467ce383d1cf638782a19b4b70691e7

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

Derek, can you please verify that this issue is fixed?

Comment 11

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed on Flame 2.2

The time does not move down on the lock screen when changing the language and locking the phone, multiple times.


Flame 2.2

Device: Flame 2.2 Master KK (319mb) (Full Flash)
Build ID: 20141015040201
Gaia: 5f1f0960ae9d22acf2a324ad37a48174d6df87f6
Gecko: 62f0b771583c
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 36.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Blocking 2.2+ for all fixed regressions.