1075275 - Remove prevent_broken_csets hook

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

prevent_broken_csets has no test coverage and has evilness such as hard-coded repository paths. Assuming it is used, we should give it some love before we upgrade hgssh to 3.1.

https://ci.mozilla.org/job/version-control-tools/coveragepy/hghooks_mozhghooks_prevent_broken_csets.html

Comment 1

[Gregory Szorc [:gps]]

Strangely, releases/mozilla-aurora is the only repository I could find that is using this hook. I'm not sure why it isn't on beta, release, esr, etc.

Since this is blocking SSH upgrade, I'll write some tests for it.

Comment 2

[Mike Hommey [:glandium]]

Huh, that would explain why I had to write another hook in bug 962300... (which does seem to be about the same issue...)

Comment 3

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #2)
> Huh, that would explain why I had to write another hook in bug 962300...
> (which does seem to be about the same issue...)

(and is still not deployed either)

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1075275/gps

Comment 5

[Gregory Szorc [:gps]]

/r/303 - hghooks: add test for prevent_broken_csets hook (bug 1075275)

Pull down this commit:

hg pull review -r ec0732d1bd254455453ffc4ae5a661fe98186f57

Comment 6

[Gregory Szorc [:gps]]

Well, I added a test. But, the hook in bug 962300 (as pointed out by glandium) is more robust than this hook.

Since prevent_broken_csets is only deployed on Aurora, I think we should deactivate the hook, delete it from source control, and finish up bug 962300 instead. It makes little sense to make to have this hook only deployed on aurora. Let's remove the server upgrade blocker and deal with bug 962300 later.

Comment 7

[Gregory Szorc [:gps]]

Let's just plan on moving forward with the deletion and eventual deployment of bug 962300's code until someone says otherwise.

Comment 8

[Gregory Szorc [:gps]]

/r/303 - hghooks: remove prevent_broken_csets hook (bug 1075275)

Pull down this commit:

hg pull review -r d10a4587c97214952f1b0c0963e75ff7c92e566e

Comment 9

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #8)
> /r/303 - hghooks: remove prevent_broken_csets hook (bug 1075275)
> 
> Pull down this commit:
> 
> hg pull review -r d10a4587c97214952f1b0c0963e75ff7c92e566e

... review board won't accept my bmo login/password.

Comment 10

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/c3a9ed12ab3d

Comment 11

[Gregory Szorc [:gps]]

bkero: please remove all traces of prevent_broken_csets from production and resolve this bug. (I think it is just mozilla-aurora, but my processes may not be as robust as yours.)

Comment 12

[Gregory Szorc [:gps]]

This bug slipped through the cracks.

The hook was only installed on mozilla-aurora. I removed it.