Remove prevent_broken_csets hook

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/680] )

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
prevent_broken_csets has no test coverage and has evilness such as hard-coded repository paths. Assuming it is used, we should give it some love before we upgrade hgssh to 3.1.

https://ci.mozilla.org/job/version-control-tools/coveragepy/hghooks_mozhghooks_prevent_broken_csets.html
(Assignee)

Updated

4 years ago
Blocks: 1053705
Product: Release Engineering → Developer Services

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/276]
(Assignee)

Comment 1

4 years ago
Strangely, releases/mozilla-aurora is the only repository I could find that is using this hook. I'm not sure why it isn't on beta, release, esr, etc.

Since this is blocking SSH upgrade, I'll write some tests for it.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Huh, that would explain why I had to write another hook in bug 962300... (which does seem to be about the same issue...)
(In reply to Mike Hommey [:glandium] from comment #2)
> Huh, that would explain why I had to write another hook in bug 962300...
> (which does seem to be about the same issue...)

(and is still not deployed either)
(Assignee)

Comment 4

4 years ago
Created attachment 8510738 [details]
MozReview Request: bz://1075275/gps
(Assignee)

Comment 5

4 years ago
/r/303 - hghooks: add test for prevent_broken_csets hook (bug 1075275)

Pull down this commit:

hg pull review -r ec0732d1bd254455453ffc4ae5a661fe98186f57
(Assignee)

Comment 6

4 years ago
Well, I added a test. But, the hook in bug 962300 (as pointed out by glandium) is more robust than this hook.

Since prevent_broken_csets is only deployed on Aurora, I think we should deactivate the hook, delete it from source control, and finish up bug 962300 instead. It makes little sense to make to have this hook only deployed on aurora. Let's remove the server upgrade blocker and deal with bug 962300 later.
(Assignee)

Comment 7

4 years ago
Let's just plan on moving forward with the deletion and eventual deployment of bug 962300's code until someone says otherwise.
Blocks: 962300
Summary: prevent_broken_csets hook untested and doing wonky things → Remove prevent_broken_csets hook
(Assignee)

Updated

4 years ago
Attachment #8510738 - Flags: review?(mh+mozilla)
(Assignee)

Comment 8

4 years ago
/r/303 - hghooks: remove prevent_broken_csets hook (bug 1075275)

Pull down this commit:

hg pull review -r d10a4587c97214952f1b0c0963e75ff7c92e566e
(In reply to Gregory Szorc [:gps] from comment #8)
> /r/303 - hghooks: remove prevent_broken_csets hook (bug 1075275)
> 
> Pull down this commit:
> 
> hg pull review -r d10a4587c97214952f1b0c0963e75ff7c92e566e

... review board won't accept my bmo login/password.
Attachment #8510738 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 11

4 years ago
bkero: please remove all traces of prevent_broken_csets from production and resolve this bug. (I think it is just mozilla-aurora, but my processes may not be as robust as yours.)
Flags: needinfo?(bkero)

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/276] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/675] [kanban:engops:https://kanbanize.com/ctrl_board/6/276]

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/675] [kanban:engops:https://kanbanize.com/ctrl_board/6/276] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/680] [kanban:engops:https://kanbanize.com/ctrl_board/6/276]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/680] [kanban:engops:https://kanbanize.com/ctrl_board/6/276] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/680]
(Assignee)

Comment 12

4 years ago
This bug slipped through the cracks.

The hook was only installed on mozilla-aurora. I removed it.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Flags: needinfo?(bkero)
You need to log in before you can comment on or make changes to this bug.