1075294 - Object.seal() should return its argument with no conversion when the argument is a primitive value

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[ziyunfei]

js> Object.seal("foo")
TypeError: "foo" is not an object
// should return "foo"

Comment 1

[ziyunfei]

Attachment: bug-1075294.patch

Comment 2

[ziyunfei]

https://tbpl.mozilla.org/?tree=Try&rev=bc3632d51f9d

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8497926 [details] [diff] [review]
bug-1075294.patch

Review of attachment 8497926 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with tiny nits addressed. Amazing that we didn't have any tests for throwing on primitives here. :(

For patches as simple as this one, you can just start a try server run right when asking for review. (As always for things like this: Linux (64 or 32, doesn't matter) only, debug only, all tests except Talos.) Then, once the reviewer gives an r+, you can either set checkin-needed directly, or upload a new version with nits addressed, carry over the r+, and note which comment the try run can be found in. If you think that, even though the reviewer gave an r+, the needed changes warrant another try run, just do that and mention it when uploading the final patch.

Spec note: I'm not particularly convinced that `success = !!(Object.seal(false))` is particularly good behavior. But then again, it also doesn't matter much: calling seal on primitives really just isn't something one should do. Also, the spec is the spec. (In this case, because I don't think it's important enough to get into discussions about. In other cases, we do give feedback to tc39 and try to fix errors.

::: js/src/builtin/Object.cpp
@@ +1092,2 @@
>  
> +    // step 1

Uber-nit: Upper-case "S" and "." at EOL, please. Here and below.

Comment 4

[ziyunfei]

Attachment: Same patch with nits addressed

Comment 5

[ziyunfei]

Got r+ at comment 3.
Green try run at comment 2.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9b59a1d80b

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d9b59a1d80b