1075405 - No SIM used by NetworkGeolocationProvider

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[:gerard-majax]

Looks like iterating on the SIM card regressed for MLS:

> 10-01 11:12:31.507   263   263 I Gecko   : *** WIFI GEO: getMobileInfo called
> 10-01 11:12:31.507   263   263 I Gecko   : *** WIFI GEO: getMobileInfo: esrvice=[xpconnect wrapped (nsISupports, nsIGonkMobileConnectionService, nsIMobileConnectionService)]
> 10-01 11:12:31.507   263   263 I Gecko   : *** WIFI GEO: getMobileInfo: found undefined MobileConnectionService

We have service.length being undefined. That makes NetworkGeolocationProvider unable to use the SIM infos to do its job.

Comment 1

[:gerard-majax]

Reproduced on Flame and on Xperia ZR: no 'Looking for SIM X' logcat message is visible.

Comment 2

[:gerard-majax]

Looks like since bug 1063304, service.length should be replaced by service.numItems.

Comment 3

[:gerard-majax]

> 10-01 11:28:56.404   261   261 I Gecko   : *** WIFI GEO: getMobileInfo called
> 10-01 11:28:56.404   261   261 I Gecko   : *** WIFI GEO: Looking for SIM in slot:0 of 1
> 10-01 11:28:56.414   261   261 I Gecko   : *** WIFI GEO: Use request cache:false reason:No cached data
> 10-01 11:28:56.414   261   261 I Gecko   : *** WIFI GEO: Sending request
> 10-01 11:28:56.414   261   261 I Gecko   : *** WIFI GEO: sending {"cellTowers":[{"radio":"lte","mobileCountryCode":"208","mobileNetworkCode":"20","locationAreaCode":30142,"cellId":128117764}]}

After the change documented in comment 2.

Comment 4

[:gerard-majax]

Attachment: Use numItems to iterate mobile connection providers r=garvank

Using .length attribute does not work anymore, probably after bug
1063304 landed. The GonkVoicemail code makes a similar use of the
MobileConnectionService and uses numItems to iterate over the providers.

Comment 5

[:garvan]

Comment on attachment 8498036 [details] [diff] [review]
Use numItems to iterate mobile connection providers r=garvank

Review of attachment 8498036 [details] [diff] [review]:
-----------------------------------------------------------------

The author of bug 1063304 should review this, and check the code for any other potential changes that were missed.

Comment 6

[:gerard-majax]

Attachment: Use numItems to iterate mobile connection providers r=echen

Using .length attribute does not work anymore, probably after bug
1063304 landed. The GonkVoicemail code makes a similar use of the
MobileConnectionService and uses numItems to iterate over the providers.

Comment 7

[:gerard-majax]

Comment on attachment 8498161 [details] [diff] [review]
Use numItems to iterate mobile connection providers r=echen

Review of attachment 8498161 [details] [diff] [review]:
-----------------------------------------------------------------

Edgar, since you reviewed bug 1063304, would you mind reviewing this? Thanks!

Comment 8

[Edgar Chen [:edgar]]

Comment on attachment 8498161 [details] [diff] [review]
Use numItems to iterate mobile connection providers r=echen

Review of attachment 8498161 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

Comment 9

[Chris Peterson [:cpeterson]]

Should we uplift this fix to B2G 2.1 (Gecko 34)?

Comment 10

[Edgar Chen [:edgar]]

(In reply to Chris Peterson (:cpeterson) from comment #9)
> Should we uplift this fix to B2G 2.1 (Gecko 34)?

bug 1063304 isn't in 2.1 branch, so we don't need to uplift this fix to 2.1, either.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/32c885eeb5bc

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/32c885eeb5bc