Closed Bug 1075504 Opened 6 years ago Closed 6 years ago

Update test_gallery_view to correlate with the manual test

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bebe, Assigned: viorela)

Details

Attachments

(2 files)

https://moztrap.mozilla.org/manage/case/14645/

The manual test says we should check that 4 option are available when we open a image in large mode

Add a assert
Assignee: nobody → viorela.ioia
Attachment #8500889 - Flags: review?(gmealer)
Attachment #8500889 - Flags: review?(florin.strugariu)
I think we need to update the moztrap testcase, as there are 5 options available when we open an image in large mode, and not 4 ~ See screenshot attached.
Peter, can you confirm this and also update the testcase? Thanks!
Flags: needinfo?(pbylenga)
Attached image screenshot.png
Modified the test case to reflect 5 options.
https://moztrap.mozilla.org/manage/case/14645/
Flags: needinfo?(pbylenga)
Comment on attachment 8500889 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24873

Looks good, but per comment in Github you should seek a second r+ before landing.
Attachment #8500889 - Flags: review?(gmealer) → review+
Attachment #8500889 - Flags: review?(florin.strugariu) → review+
merged in https://github.com/mozilla-b2g/gaia/commit/3c6c51abccbbeabab2f691a75331c9b7cecc27a5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Should we uplift these bugs to v2.1?
Flags: needinfo?(gmealer)
I don't see why not, but what have we typically done in the past? I'm unsure how 2.1 uplift rules end up applying to these tests.
Flags: needinfo?(gmealer)
Blocks: 1093874
No longer blocks: 1093874
QA Whiteboard: [fxosqa-auto-s1]
You need to log in before you can comment on or make changes to this bug.