1075504 - Update test_gallery_view to correlate with the manual test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

https://moztrap.mozilla.org/manage/case/14645/

The manual test says we should check that 4 option are available when we open a image in large mode

Add a assert

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24873

Comment 2

[Viorela Ioia [:viorela]]

I think we need to update the moztrap testcase, as there are 5 options available when we open an image in large mode, and not 4 ~ See screenshot attached.
Peter, can you confirm this and also update the testcase? Thanks!

Comment 3

[Viorela Ioia [:viorela]]

Attachment: screenshot.png

Comment 4

[Peter Bylenga [:PBylenga]]

Modified the test case to reflect 5 options.
https://moztrap.mozilla.org/manage/case/14645/

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 8500889 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24873

Looks good, but per comment in Github you should seek a second r+ before landing.

Comment 6

[Florin Strugariu [:Bebe]]

merged in https://github.com/mozilla-b2g/gaia/commit/3c6c51abccbbeabab2f691a75331c9b7cecc27a5

Comment 7

[Florin Strugariu [:Bebe]]

Should we uplift these bugs to v2.1?

Comment 8

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I don't see why not, but what have we typically done in the past? I'm unsure how 2.1 uplift rules end up applying to these tests.