Standalone UI for link clickers needs "call failed" audio notification

RESOLVED FIXED in Firefox 35

Status

Hello (Loop)
Client
P3
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: NiKo, Assigned: tOkeshu)

Tracking

unspecified
mozilla36
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

(Whiteboard: [standalone])

Attachments

(1 attachment, 4 obsolete attachments)

This is a follow up of bug 1000240. We need to play a specific sound when a call fails in the Loop conversation window.
Created attachment 8498147 [details]
Call failed notification sound.
Created attachment 8504072 [details] [diff] [review]
Play a sound on failed call in Loop standalone.
Attachment #8504072 - Flags: review?(standard8)
Comment on attachment 8504072 [details] [diff] [review]
Play a sound on failed call in Loop standalone.

Cacelling the review for now as work in bug 1065203 will introduce a reusable AudioMixin providing exactly what we want here.
Attachment #8504072 - Flags: review?(standard8)
backlog: --- → Fx36?
(Assignee)

Updated

4 years ago
Assignee: nobody → rgauthier
(Assignee)

Comment 4

4 years ago
Created attachment 8512668 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

The patch uses the AudioMixin introduced by Bug 1065203.
The sound used is the one corresponding to failed calls (see Bug 1065203 for the sound file).
Attachment #8498147 - Attachment is obsolete: true
Attachment #8504072 - Attachment is obsolete: true
Attachment #8512668 - Flags: review?(standard8)
Attachment #8512668 - Flags: review?(nperriault)
(Assignee)

Comment 5

4 years ago
Created attachment 8512673 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound
Attachment #8512668 - Attachment is obsolete: true
Attachment #8512668 - Flags: review?(standard8)
Attachment #8512668 - Flags: review?(nperriault)
Attachment #8512673 - Flags: review?(standard8)
Attachment #8512673 - Flags: review?(nperriault)
Comment on attachment 8512673 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Review of attachment 8512673 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the missing test added.

::: browser/components/loop/standalone/content/js/webapp.jsx
@@ +572,5 @@
>    var FailedConversationView = React.createClass({
> +    mixins: [sharedMixins.AudioMixin],
> +
> +    componentDidMount: function() {
> +      this.play("failure");

Don't we want a test for this?
Attachment #8512673 - Flags: review?(nperriault) → review+
Attachment #8512673 - Flags: review?(standard8)
(Assignee)

Comment 7

4 years ago
Created attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

I added a test, as well as the corresponding sound file I forgot in the last patch :B
Attachment #8513526 - Flags: review?(nperriault)

Updated

4 years ago
backlog: Fx36? → Fx35+
Priority: -- → P3
Whiteboard: [standalone]
Comment on attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Review of attachment 8513526 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8513526 - Flags: review?(nperriault) → review+
Attachment #8512673 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f9e9a9e2afba
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Flags: in-testsuite?

Updated

4 years ago
Iteration: --- → 36.2
status-firefox35: --- → fixed
status-firefox36: --- → fixed
Comment on attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8513526 - Flags: approval-mozilla-aurora?
Attachment #8513526 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Clearing in-testsuite requests for features that are being removed from Hello as part of te user journey work in bug 1209713.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.