Closed Bug 1075509 Opened 5 years ago Closed 5 years ago

Standalone UI for link clickers needs "call failed" audio notification

Categories

(Hello (Loop) :: Client, defect, P3)

defect

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.2
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: NiKo, Assigned: rgauthier)

References

Details

(Whiteboard: [standalone])

Attachments

(1 file, 4 obsolete files)

This is a follow up of bug 1000240. We need to play a specific sound when a call fails in the Loop conversation window.
Comment on attachment 8504072 [details] [diff] [review]
Play a sound on failed call in Loop standalone.

Cacelling the review for now as work in bug 1065203 will introduce a reusable AudioMixin providing exactly what we want here.
Attachment #8504072 - Flags: review?(standard8)
backlog: --- → Fx36?
Assignee: nobody → rgauthier
The patch uses the AudioMixin introduced by Bug 1065203.
The sound used is the one corresponding to failed calls (see Bug 1065203 for the sound file).
Attachment #8498147 - Attachment is obsolete: true
Attachment #8504072 - Attachment is obsolete: true
Attachment #8512668 - Flags: review?(standard8)
Attachment #8512668 - Flags: review?(nperriault)
Attachment #8512668 - Attachment is obsolete: true
Attachment #8512668 - Flags: review?(standard8)
Attachment #8512668 - Flags: review?(nperriault)
Attachment #8512673 - Flags: review?(standard8)
Attachment #8512673 - Flags: review?(nperriault)
Comment on attachment 8512673 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Review of attachment 8512673 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the missing test added.

::: browser/components/loop/standalone/content/js/webapp.jsx
@@ +572,5 @@
>    var FailedConversationView = React.createClass({
> +    mixins: [sharedMixins.AudioMixin],
> +
> +    componentDidMount: function() {
> +      this.play("failure");

Don't we want a test for this?
Attachment #8512673 - Flags: review?(nperriault) → review+
Attachment #8512673 - Flags: review?(standard8)
I added a test, as well as the corresponding sound file I forgot in the last patch :B
Attachment #8513526 - Flags: review?(nperriault)
backlog: Fx36? → Fx35+
Priority: -- → P3
Whiteboard: [standalone]
Comment on attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Review of attachment 8513526 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8513526 - Flags: review?(nperriault) → review+
Attachment #8512673 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f9e9a9e2afba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: qe-verify-
Flags: in-testsuite?
Iteration: --- → 36.2
Comment on attachment 8513526 [details] [diff] [review]
Bug 1075509: Standalone UI needs "call failed" sound

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8513526 - Flags: approval-mozilla-aurora?
Attachment #8513526 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Clearing in-testsuite requests for features that are being removed from Hello as part of te user journey work in bug 1209713.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.