Update test_sms_contact to send the SMS message

RESOLVED FIXED

Status

Firefox OS
Gaia::TestAgent
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Bebe, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
test_sms_add_contact writes the SMS but it's not sending it.

Update the test to send the SMS and correlate with https://moztrap.mozilla.org/manage/case/6305/
(Assignee)

Updated

4 years ago
Assignee: nobody → viorela.ioia
(Assignee)

Updated

4 years ago
Summary: Update test_sms_add_contact to send the SMS message → Update test_sms_contact to send the SMS message
(Assignee)

Comment 1

4 years ago
Created attachment 8500491 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24839
Attachment #8500491 - Flags: review?(gmealer)
Attachment #8500491 - Flags: review?(florin.strugariu)
(Assignee)

Updated

4 years ago
Attachment #8500491 - Flags: review?(robert.chira)
Comment on attachment 8500491 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24839

Looks good to me, minor concern about local variable naming aside. Per Github comment, you should seek another r+ before landing.
Attachment #8500491 - Flags: review?(gmealer) → review+
(Reporter)

Comment 3

4 years ago
Comment on attachment 8500491 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24839

small nit in var naming but the rest looks OK
Attachment #8500491 - Flags: review?(florin.strugariu) → review+
(Reporter)

Updated

4 years ago
Attachment #8500491 - Flags: review?(robert.chira)
(Reporter)

Comment 4

4 years ago
https://github.com/mozilla-b2g/gaia/commit/5d0c43daff8aeb56e3a29b5f31c4a7f4cfa76463
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-s1]
You need to log in before you can comment on or make changes to this bug.