1075558 - Notifications.jsm - unregisterHandler code is incorrect - splice is not a function of object

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[tonyhallett74]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140917194002

Steps to reproduce:

Just call Notifications.unregisterHandler


Actual results:

_handlersMap.splice is not a function


Expected results:

correct code should be _handlersMap[key].splice(i, 1);

Comment 1

[Richard Newman [:rnewman]]

Attachment: Fix Notifications.unregisterHandler. v1

Should be easy enough.

Comment 2

[Richard Newman [:rnewman]]

Attachment: Fix Notifications.unregisterHandler. v2

Fixed some warts while I'm here.

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/c0b11eac9361

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c0b11eac9361

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8540929 [details] [diff] [review]
Fix Notifications.unregisterHandler. v2

Approval Request Comment
[Feature/regressing bug #]:
  Bug 1004495.

[User impact if declined]:
  Impossible for add-ons to unregister for notifications; they'll cause a JS error if they try.

[Describe test coverage new/current, TBPL]:
  No tests. Obvious fix, effectively a one-liner.

[Risks and why]: 
  Low risk. Fixes a public API.

[String/UUID change made/needed]:
  None.

Comment 6

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/219a0ba28658

Comment 7

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8bdb452f0ece