Closed Bug 1075558 Opened 6 years ago Closed 5 years ago

Notifications.jsm - unregisterHandler code is incorrect - splice is not a function of object

Categories

(Firefox for Android :: General, defect)

35 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 37
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: tonyhallett74, Assigned: rnewman)

References

()

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140917194002

Steps to reproduce:

Just call Notifications.unregisterHandler


Actual results:

_handlersMap.splice is not a function


Expected results:

correct code should be _handlersMap[key].splice(i, 1);
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → Android
Hardware: x86_64 → ARM
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Should be easy enough.
Attachment #8540928 - Flags: review?(margaret.leibovic)
Fixed some warts while I'm here.
Attachment #8540929 - Flags: review?(margaret.leibovic)
Attachment #8540928 - Attachment is obsolete: true
Attachment #8540928 - Flags: review?(margaret.leibovic)
Attachment #8540929 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/c0b11eac9361
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Comment on attachment 8540929 [details] [diff] [review]
Fix Notifications.unregisterHandler. v2

Approval Request Comment
[Feature/regressing bug #]:
  Bug 1004495.

[User impact if declined]:
  Impossible for add-ons to unregister for notifications; they'll cause a JS error if they try.

[Describe test coverage new/current, TBPL]:
  No tests. Obvious fix, effectively a one-liner.

[Risks and why]: 
  Low risk. Fixes a public API.

[String/UUID change made/needed]:
  None.
Attachment #8540929 - Flags: approval-mozilla-beta?
Attachment #8540929 - Flags: approval-mozilla-aurora?
Attachment #8540929 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8540929 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.