Closed
Bug 1075558
Opened 10 years ago
Closed 9 years ago
Notifications.jsm - unregisterHandler code is incorrect - splice is not a function of object
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox35 fixed, firefox36 fixed, firefox37 fixed)
RESOLVED
FIXED
Firefox 37
People
(Reporter: tonyhallett74, Assigned: rnewman)
References
()
Details
Attachments
(1 file, 1 obsolete file)
2.15 KB,
patch
|
mcomella
:
review+
Sylvestre
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 Build ID: 20140917194002 Steps to reproduce: Just call Notifications.unregisterHandler Actual results: _handlersMap.splice is not a function Expected results: correct code should be _handlersMap[key].splice(i, 1);
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → Android
Hardware: x86_64 → ARM
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Should be easy enough.
Attachment #8540928 -
Flags: review?(margaret.leibovic)
Assignee | ||
Comment 2•9 years ago
|
||
Fixed some warts while I'm here.
Attachment #8540929 -
Flags: review?(margaret.leibovic)
Assignee | ||
Updated•9 years ago
|
Attachment #8540928 -
Attachment is obsolete: true
Attachment #8540928 -
Flags: review?(margaret.leibovic)
Attachment #8540929 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c0b11eac9361
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c0b11eac9361
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8540929 [details] [diff] [review] Fix Notifications.unregisterHandler. v2 Approval Request Comment [Feature/regressing bug #]: Bug 1004495. [User impact if declined]: Impossible for add-ons to unregister for notifications; they'll cause a JS error if they try. [Describe test coverage new/current, TBPL]: No tests. Obvious fix, effectively a one-liner. [Risks and why]: Low risk. Fixes a public API. [String/UUID change made/needed]: None.
Attachment #8540929 -
Flags: approval-mozilla-beta?
Attachment #8540929 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8540929 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Attachment #8540929 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•