Closed Bug 1075617 Opened 6 years ago Closed 6 years ago

Log the correct file/line for font errors

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Log the correct file/line for the @font-face rule for font errors
2.24 KB, patch
jfkthame
: review+
Details | Diff | Splinter Review 
We should be getting the line number from the rule, and the correct URI from the sheet, not the brain-damaged DOM URI.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8498239 [details] [diff] [review]
Log the correct file/line for the @font-face rule for font errors

Review of attachment 8498239 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. (How did we ever land that logging code in such a broken form?! Yes, I do see who the blame points at.... oh, wait, until bug 591303 I don't think we had any way of getting the line/column numbers, so that partially explains things.)
Attachment #8498239 - Flags: review?(jfkthame) → review+
Yeah, indeed.  We used to have no way to get the column/line, and the fact that GetHref() returns null for inline style sheets is not obvious.  :(
https://hg.mozilla.org/mozilla-central/rev/6351a349b35d
https://hg.mozilla.org/mozilla-central/rev/33a3fd4d1970
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.