Closed
Bug 1075617
Opened 11 years ago
Closed 11 years ago
Log the correct file/line for font errors
Categories
(Core :: Graphics: Text, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
2.24 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
We should be getting the line number from the rule, and the correct URI from the sheet, not the brain-damaged DOM URI.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8498239 -
Flags: review?(jfkthame)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8498239 [details] [diff] [review]
Log the correct file/line for the @font-face rule for font errors
Review of attachment 8498239 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. (How did we ever land that logging code in such a broken form?! Yes, I do see who the blame points at.... oh, wait, until bug 591303 I don't think we had any way of getting the line/column numbers, so that partially explains things.)
Attachment #8498239 -
Flags: review?(jfkthame) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yeah, indeed. We used to have no way to get the column/line, and the fact that GetHref() returns null for inline style sheets is not obvious. :(
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6351a349b35d and https://hg.mozilla.org/integration/mozilla-inbound/rev/33a3fd4d1970 as a followup to deal with the null rule case.
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6351a349b35d
https://hg.mozilla.org/mozilla-central/rev/33a3fd4d1970
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•