1075985 - Steeplechase does not work with Mac v2 codesigning application layout

Status: RESOLVED INVALID

(Testing :: General, defect)

Description

[Syd Polk :sydpolk]

These folders are no longer in the same folder as the firefox binary:

browser
defaults
dictionaries

steeplechase takes a --binary parameter which for mac is Firefox.app/Contents/MacOS/firefox. There is an implicit assumption that just copying the existing directory around firefox is enough to launch firefox; this is not valid with v2 layout.

I don't know what the solution is.

Comment 1

[cmtalbert]

I believe (though I haven't looked in a long time) the Contents/MacOS/firefox is actually a script that is supposed to set the paths correctly for SO's & Dylibs (it's a script on both linux and mac) and that it then calls the firefox-bin binary.

That could be ancient history as I haven't dug into mac details in quite a while. So if Steeplechase moves the entire dmg over and unpacks it on the local machine this should be fixed (because that script has to work on a local machine since otherwise firefox wouldn't start at all).

Comment 2

[Nils Ohlmeier [:drno]]

(In reply to Clint Talbert ( :ctalbert ) from comment #1)
> I believe (though I haven't looked in a long time) the
> Contents/MacOS/firefox is actually a script that is supposed to set the
> paths correctly for SO's & Dylibs (it's a script on both linux and mac) and
> that it then calls the firefox-bin binary.

Just an FYI: this does not seem to be the case (any more) for FF 32 - 35 I have this:

$ ls -l firefox*
-rwxr-xr-x  1 nohlmeier  admin  125040 Oct  1 13:28 firefox
-rwxr-xr-x  1 nohlmeier  admin  125008 Oct  1 13:28 firefox-bin

$ file firefox*
firefox:     Mach-O universal binary with 2 architectures
firefox (for architecture x86_64):	Mach-O 64-bit executable x86_64
firefox (for architecture i386):	Mach-O executable i386
firefox-bin: Mach-O universal binary with 2 architectures
firefox-bin (for architecture x86_64):	Mach-O 64-bit executable x86_64
firefox-bin (for architecture i386):	Mach-O executable i386

No idea why we actually ship two slightly different binaries for MacOS?!

Comment 3

[Syd Polk :sydpolk]

We are going to solve this with work on https://bugzilla.mozilla.org/show_bug.cgi?id=1025055.

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Nils Ohlmeier [:drno] from comment #2)
> No idea why we actually ship two slightly different binaries for MacOS?!

firefox-bin is just a leftover from when that used to be the actual binary. It broke things when we tried to remove it so we left it. If I had to guess I'd guess that we're signing 'firefox' and not 'firefox-bin'.

Comment 5

[Syd Polk :sydpolk]

I don't think that this should be specifically fixed. Passing the entire package (https://bugzilla.mozilla.org/show_bug.cgi?id=1025055) obviates the need for this to be fixed.