107642 - Land giant xul patch

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Blake Ross]

Tracking the landing of the xul syntax changes and cleaning outlined in
n.p.m.xpfe over the past month.

Comment 1

[Blake Ross]

Attachment: patch

Comment 2

[Blake Ross]

Comment on attachment 56047 [details] [diff] [review]
patch

rs=ben pending module owner approval

Comment 3

[Blake Ross]

Attachment: mail portion

Comment 4

[Blake Ross]

- The html namespace is being removed from root tags. It's no longer necessary,
and is just left over from the days when we used html widgets in xul.

- The orient="vertical" attribute is being removed from root tags,
<radiogroup/>, <tabpanels/> and <groupbox/> because it's now the default
orientation for those elements.  Orient="horizontal" is being removed from
<tabs/> because that's its default orientation.

- The <text/> and <html/> tags are being changed to <label/> and <description/>
as appropriate (label is for widget labeling, description is for general
introductory text and so forth).

- The autostretch attribute is being removed, replaced by align="center" for
horizontal boxes and align="left" for vertical boxes (bug 94470).

- pref="true" is being removed from all elements as it is now unnecessary. Many
prefattributes and prefvalues are also being removed because certain elements
have been given reasonable defaults (see bugs 102366 and 102367).

- The group attribute is being removed from all <radio/>s because it's now
unnecessary, and |checked| has changed to |selected| (see bugs 96008, 94222 and
96019). already sr'd by hyatt.

- A couple <window/>s have been converted to <dialog/>s, the rest will be done
as part of bug 102637.

- The for attribute is being changed to control.

- All trees are now inset by default, as that is the common case.

- Removal of lots of unnecessary or just completely nonsensical usages, like
<button flex="50%"/>, <label text-align="right"/>, <button class="dialog"/>, and
other stuff.

In total, over 1000 attributes are removed.  Some minor visual defects may occur
from this patch (stuff like something having a margin one pixel too large). Joe
and I have pledged to stand around with our pooper scoopers after checkin.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 56083 [details] [diff] [review]
mail portion

sr=sspitzer, make sure to test well.

Comment 6

[Blake Ross]

Attachment: editor portion

Comment 7

[Charles Manske]

Comment on attachment 56095 [details] [diff] [review]
editor portion

r=cmanske

Comment 8

[Charles Manske]

Upon further consideration, I'd like it if you didn't remove these lines:
-  <separator class="groove"/>

in EdHLineProps.xul, EdInsertChars.xul, and EdPageProps.xul.
They are all near the bottom of the dialog, just above:
-  <!-- from global dialogOverlay -->
-  <hbox id="okCancelButtonsRight"/>

Comment 9

[Blake Ross]

The eagle has landed. May the bugs flow like honey!

Comment 10

[(not reading, please use [e-mail] instead)]

"make sure to test well."

did you test these changes?  mozilla is busted all over.

Comment 11

[Blake Ross]

Mozilla is not "busted all over".  Profile manager was broken because I forgot
to commit from /profile last night (I could not do a top level commit or bonsai
would break). Yes, there are some UI defects. I said there would be before I
checked in. That's why I checked in on a friday night, on a weekend when there
would be no builds, so I could clean up.

Comment 12

[Roland Mainz]

blake:
Could you please help fixing the patch in bug 84947 (the new XUL printdialog for
OS/2+Unix/Linux) ? The landing of this bug shot the current patch dead... ;-(

Comment 13

[Charles Manske]

Note that this patch killed some Composer dialogs (bug 108670) because we used
<html:br/> in DTD strings to control text wrapping. Now that support for HTML is
removed, how can we control breaks in DTD strings?

Comment 14

[Blake Ross]

Support for html tags in xul dialogs is not removed. Just readd the xmlns:html 
line to the root tag.  However, you should not need to use html tags.

Comment 15

[andreww]

Removing the class="inset" from the trees in prefs.xul has rendered all 
the trees in mac classic to have no border.  Was the removal of the class 
intentional?  

see bug http://bugzilla.mozilla.org/show_bug.cgi?id=108789