1076428 - Only register with the push server, not as a guest too when using FxA after a restart

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P4)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Post-bug 1047133, authenticated users will register with the Loop server for Guest registration and then for FxA registration. We should investigate how we can reduce the Guest registration in this case, as it is unnecessary and generates more traffic for the server.

Comment 1

[Mark Banner (:standard8)]

The guest registration will be needed for urls shared (in the 34 case) generated before a user signed-in.

Guest registration used to automatically stop after those urls expire (currently 30 days).

I haven't looked at the code, but have we separated that functionality from the FxA registration?

IMO, I think we want guest registration to still automatically stop, but FxA to always happen if a user is signed in (because of direct calling).

Something similar will probably relate to rooms, though rooms will default to being around a little bit longer.

Comment 2

[Matthew N. [:MattN]]

What we did is make it register as a guest if either of the following are true:
* there is a guest URL which hasn't expired (same as before) OR
* there is an active FxA session

The reason for this is because our push registration is currently tightly coupled with guest registration. FxA automatic re-login really only needs the push registration but due to the coupling we implemented this for now.

My hope is that we can separate them better and maybe that will happen with rooms.

Comment 3

[Matthew N. [:MattN]]

P4 for now unless this affects scalability.

Comment 4

[Matthew N. [:MattN]]

I fixed this as part of bug 1093500 as I kept it in mind while refactoring.

Comment 5

[Matthew N. [:MattN]]

I updated test_loopservice_restart.js in that bug so there is a basic sanity test for this.