107664 - disable debug message in optimized build

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Yuying Long]

Build: N6.2 RTM build, 10-26 trunk build on RedHat7.1-Ja

Steps to reproduce:
1. Create a Japanese profile name.
2. Launch browser by using the profile in step 1.

Result:
You will see the Japanese characters in profile name are display as "..." after
StartApprunner step. - a screen shot will followed.

Comment 1

[Yuying Long]

Attachment: screen shot of terminal window

Comment 2

[Roy Yokoyama]

ylong: similar to 101581 but in the linux platform.
patch in 104305 should fix this bug. 
Please verify once it's checked in. 

*** This bug has been marked as a duplicate of 101581 ***

Comment 3

[kill this account]

This relates to output not input and hence seems unrelated to bug 101581.

Here is the code that outputs the string:

http://lxr.mozilla.org/seamonkey/source/profile/src/nsProfile.cpp#1827
1827 #if defined(DEBUG_profile)
1828     {
1829       printf("ProfileManager : StartApprunner\n");
1830 
1831       printf("profileName passed in: %s\n", 
NS_LossyConvertUCS2toASCII(profileName).get());
1832     }
1833 #endif

Note that this is bracketed in DEBUG_profile.

Also note the use of NS_LossyConvertUCS2toASCII. 
Shouldn't we have used a convert UCS2 to locale conversion here?

Comment 4

[Yuying Long]

Sorry, but I think I have to re-open this one - I still see it on 11-16 trunk
build, while bug 101581 (bug 104305) was fixed.

Comment 5

[Roy Yokoyama]

linux->shanjian

Comment 6

[Shanjian Li]

Attachment: patch

Comment 7

[Shanjian Li]

daniel, 
I think it is time to get rid of debug info from default build. This should have
been done before any RTM. I checked all the debug message, and I believe it is
OK to disable them. Please r= and I will drive it in. 
thanks.

 

Comment 8

[Dan M]

who, me? OK r=danm. The patch, coincidentally, is a change I've been running
with in my builds for ages. I have a perl script that fixes annoying things any
time I do a fresh checkout, and that's one of the things it does for me.

Comment 9

[Shanjian Li]

chris, need your rubber stamp here. Could you sr? 

Comment 10

[Chris Waterson]

Comment on attachment 59722 [details] [diff] [review]
patch 

sr=waterson. Yay!

Comment 11

[Shanjian Li]

fix checked in. 

Comment 12

[Yuying Long]

Verified the debug message has been removed on 11-30 linux trunk build.