Closed
Bug 107664
Opened 23 years ago
Closed 23 years ago
disable debug message in optimized build
Categories
(Core :: Internationalization, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: amyy, Assigned: shanjian)
Details
(Keywords: intl)
Attachments
(2 files)
13.70 KB,
image/png
|
Details | |
566 bytes,
patch
|
shanjian
:
review+
waterson
:
superreview+
|
Details | Diff | Splinter Review |
Build: N6.2 RTM build, 10-26 trunk build on RedHat7.1-Ja Steps to reproduce: 1. Create a Japanese profile name. 2. Launch browser by using the profile in step 1. Result: You will see the Japanese characters in profile name are display as "..." after StartApprunner step. - a screen shot will followed.
Reporter | ||
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
ylong: similar to 101581 but in the linux platform. patch in 104305 should fix this bug. Please verify once it's checked in. *** This bug has been marked as a duplicate of 101581 ***
Comment 3•23 years ago
|
||
This relates to output not input and hence seems unrelated to bug 101581. Here is the code that outputs the string: http://lxr.mozilla.org/seamonkey/source/profile/src/nsProfile.cpp#1827 1827 #if defined(DEBUG_profile) 1828 { 1829 printf("ProfileManager : StartApprunner\n"); 1830 1831 printf("profileName passed in: %s\n", NS_LossyConvertUCS2toASCII(profileName).get()); 1832 } 1833 #endif Note that this is bracketed in DEBUG_profile. Also note the use of NS_LossyConvertUCS2toASCII. Shouldn't we have used a convert UCS2 to locale conversion here?
Reporter | ||
Comment 4•23 years ago
|
||
Sorry, but I think I have to re-open this one - I still see it on 11-16 trunk build, while bug 101581 (bug 104305) was fixed.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
daniel, I think it is time to get rid of debug info from default build. This should have been done before any RTM. I checked all the debug message, and I believe it is OK to disable them. Please r= and I will drive it in. thanks.
Status: NEW → ASSIGNED
Summary: The Japanese profile name is display as "..." in terminal window → disable debug message in optimized build
who, me? OK r=danm. The patch, coincidentally, is a change I've been running with in my builds for ages. I have a perl script that fixes annoying things any time I do a fresh checkout, and that's one of the things it does for me.
Assignee | ||
Updated•23 years ago
|
Attachment #59722 -
Flags: review+
Assignee | ||
Comment 9•23 years ago
|
||
chris, need your rubber stamp here. Could you sr?
Comment 10•23 years ago
|
||
Comment on attachment 59722 [details] [diff] [review] patch sr=waterson. Yay!
Attachment #59722 -
Flags: superreview+
Assignee | ||
Comment 11•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•23 years ago
|
||
Verified the debug message has been removed on 11-30 linux trunk build.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•