Closed Bug 1076695 Opened 5 years ago Closed 5 years ago

Don't convert alpha surfaces into RGBA surfaces for FilterNodeTransformSoftware

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
This is not that important, just a patch I had in my queue. It removes one use of NEED_COLOR_CHANNELS and modernizes the DrawTarget/DataSourceSurface interaction.
Attachment #8498666 - Flags: review?(bas)
Attachment #8498666 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/bb80c2b08bc0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f622aedd4348 as being the likely cause of the ASAN-only reftest permafail from bug 1079594
Status: RESOLVED → REOPENED
Flags: needinfo?(mstange)
Resolution: FIXED → ---
Target Milestone: mozilla35 → ---
Attached patch v2Splinter Review
Duh, I wasn't clearing the output surface before drawing into it.
Attachment #8498666 - Attachment is obsolete: true
Flags: needinfo?(mstange)
https://hg.mozilla.org/mozilla-central/rev/347e06a0c06c
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.