1076701 - [Contact] Improve UI on index circle for the Contact list

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Carol Huang [:Carol]]

Attachment: screenshot.png

the index circle need some adjustment.

Comment 1

[Carol Huang [:Carol]]

I need info Fang for the UI spec.

Comment 2

[Fang Shih [:fang]]

Attachment: Contact_newindex.png

Attached the new visual spec, Thanks!

Comment 3

[Olof Wickström]

This looks bad. Please fix

Comment 4

[Johan Lorenzo [:jlorenzo]]

Triage: This issue is a minor UI polish and cannot be considered as a blocker then (https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Not_Block). Moreover, the current implementation was signed off for 2.1 weeks ago.

Comment 5

[Wilfred Mathanaraj [:WDM]]

As discussed can we look at the possibility to take this in case we are done with all our blockers?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Will schedule it for next sprint, will take in this if we run out of work to do :P

Comment 7

[Francis Lee [:frlee]]

Partner raised serious concern as this doesn't pass their UX criteria for v2.1. 
raised internal discussion for getting approval. (wilfred, wesley are in the loop)

may i understand the effort and the risk to fix this issue?

Comment 8

[Jose Manuel Cantera]

I can take this bug if Pavel is swamped and happy to do reviews as well.

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yes, please :)

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Hopefuly will be just a css change

Comment 11

[Jose Manuel Cantera]

Attachment: 25768.html

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8515932 [details]
25768.html

only one nit:

"background: rgba(80, 80, 80, 0.8);"
can we use "background-color" instead "background"

Comment 13

[Francis Lee [:frlee]]

hi Bhavana,

since it's review+, i would like to request approval to uplift to 2.1

Comment 14

[Fang Shih [:fang]]

Comment on attachment 8515932 [details]
25768.html

Overall it looks good. Just want to make sure the highlighted letter is horizontal / vertical centered inside of highlight circle. Now it seems a bit high. Thanks!

Comment 15

[Jose Manuel Cantera]

(In reply to Fang Shih [:grasspizza] from comment #14)
> Comment on attachment 8515932 [details]
> 25768.html
> 
> Overall it looks good. Just want to make sure the highlighted letter is
> horizontal / vertical centered inside of highlight circle. Now it seems a
> bit high. Thanks!

Fang, the content inside the circle is both vertically and horizontally aligned. Probably that misalignment can be due to the different sizes of the different letters and the font family characteristics. I'm gonna land it. Please file a new bug in case you still feel there is a misalignment.

Comment 16

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/5b185fb3c26a814787b544cc9ef2770a8b223ec6

Comment 17

[Jose Manuel Cantera]

Comment on attachment 8515932 [details]
25768.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual refresh contacts app
[User impact] if declined: Poor UX perception
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): No-risk patch. Only CSS changes
[String changes made]: none

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/4c159e75a1568afbbf0c83c1235ec56facfbe87d

Comment 19

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.1 & 2.2.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.1 version:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0

Flame 2.2 version:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1