1076746 - Mentor field is missing in the email when a bug gets created

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since we make use of the mentor field on Bugzilla we make heavy use of it in our team. Something which is annoying right now, is that the field does not appear all the other fields for the email sent out when a new bug gets created. I have to constantly open the bug, and manually check for the right mentor.

Can we please get the mentor field added to the list?

Comment 1

[Andrei Eftimie]

With this it should be nice to also add it into the Feed:
(ie. https://bugzilla.mozilla.org/buglist.cgi?component=Mozmill%20Tests&list_id=11285489&product=Mozilla%20QA&query_format=advanced&resolution=---&title=Bug%20List&title=Bug%20List&ctype=atom )

Comment 2

[David Lawrence [:dkl]]

Will see what I can do as this field is not editable via the admin UI. I will need a DBA to toggle a column value for us directly.

(In reply to Andrei Eftimie from comment #1)
> With this it should be nice to also add it into the Feed:
> (ie.
> https://bugzilla.mozilla.org/buglist.
> cgi?component=Mozmill%20Tests&list_id=11285489&product=Mozilla%20QA&query_for
> mat=advanced&resolution=---&title=Bug%20List&title=Bug%20List&ctype=atom )

The columns that display are configurable. Just pass in a variable called 'columnlist=' in the url with a comma delimited list of columns you want to be included. The name for the Mentor column is 'bug_mentor'. So it would be something like:

https://bugzilla.mozilla.org/buglist.
cgi?component=Mozmill%20Tests&product=Mozilla%20QA&resolution=---&title=Bug%20List&title=Bug%20List&ctype=atom&columnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate%2Cbug_mentor

dkl

Comment 3

[Andrei Eftimie]

Ah nice, thanks David!

Comment 4

[David Lawrence [:dkl]]

Attachment: 1076746_1.patch

Comment 5

[:glob ✱]

Comment on attachment 8502050 [details] [diff] [review]
1076746_1.patch

Review of attachment 8502050 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: extensions/Review/Extension.pm
@@ +927,4 @@
>          });
>      }
> +    else {
> +        if (!$field->in_new_bugmail) {

nit: no need for the extra nesting here, elsif will work.

Comment 6

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   713077f..83eac0c  master -> master

Still need to get the DBA to toggle the mailhead value for bug_mentor in fielddefs so leaving bug open for now.

dkl

Comment 7

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #6)
> Still need to get the DBA to toggle the mailhead value for bug_mentor in
> fielddefs so leaving bug open for now.

we shouldn't be do anything that requires direct db manipulation because we cached data won't be updated.
regardless this isn't necessary as the code calls $field->set_in_new_bugmail(1) in install_update_db.

Comment 8

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #7)
> (In reply to David Lawrence [:dkl] from comment #6)
> > Still need to get the DBA to toggle the mailhead value for bug_mentor in
> > fielddefs so leaving bug open for now.
> 
> we shouldn't be do anything that requires direct db manipulation because we
> cached data won't be updated.
> regardless this isn't necessary as the code calls
> $field->set_in_new_bugmail(1) in install_update_db.

Ugh brain fart. I remember now that I fgured out I could do the update in install_update_db and originally thought I would need DBA intervention. And thanks for reminder about the memcache quirks for the future.

dkl