Closed
Bug 1076765
Opened 10 years ago
Closed 10 years ago
possibly undefined mRadioChildren property in radio.xml
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file, 1 obsolete file)
1.03 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
Looks like the reference to "mRadioChildren" member in radio.xml is bogus, there is no such property defined anywhere. http://mxr.mozilla.org/comm-central/search?string=mradiochildren&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central /mozilla/toolkit/content/widgets/radio.xml (View Hg log or Hg annotations) line 459 -- var radioList = this.radioGroup.mRadioChildren; I suppose it should have been "_radioChildren" and will prepare a patch doing that. Looks like this was missed in bug 371260. It is unknown to me whether this causes any visible problems. Probably not when it went unnoticed for 7 years.
Attachment #8499049 -
Flags: review?(neil)
Comment 2•10 years ago
|
||
Comment on attachment 8499049 [details] [diff] [review] patch radioGroup is wrong too, but exists for backward compatibility. r=me if you correct that too (in both places).
Attachment #8499049 -
Flags: review?(neil) → review+
Attachment #8499049 -
Attachment is obsolete: true
Attachment #8499672 -
Flags: review+
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e048332ea306
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e048332ea306
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•