1076790 - event.returnValue = false doesn't work

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[cakkavati.kusuma]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
Build ID: 20140605174243

Steps to reproduce:

I tried the codes from this site : http://www.sanwebe.com/2012/09/ajax-multiple-image-upload-resize-with-jquery-and-php




Actual results:

The javascript can't run. I have test it in other browser and can run properly.


Expected results:

I can see some input file.

Comment 1

[Loic]

Provide a simple testcase to attach to the bug, please.

Comment 2

[YF (Yang)]

I see the "ReferenceError: event is not defined   ajax-multi-image-upload-progressbar:27" in console when click the "Add More Files".

I think he was referring to above.

Comment 3

[Loic]

The error is in:
$("#AddMoreFileBox").click(function () {
		event.returnValue = false;
}

"event.returnValue = false" is deprecated and the demo is using an old version of jQuery (1.10.2). I guess updating jQuery should be enough or changing the part of code by:
$("#AddMoreFileBox").click(function (event) {
		event.returnValue = false;
}

or

$("#AddMoreFileBox").click(function (event) {
		event.preventDefault();
}

* http://stackoverflow.com/questions/17712796/both-event-preventdefault-and-event-returnvalue-false-dont-work-in-firefox
* http://stackoverflow.com/questions/20045162/event-returnvalue-is-deprecated-please-use-the-standard-event-preventdefault