1076841 - getUserMedia Video broken due to delayed init of MediaPlayers

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Samsung Galaxy S5 (Android 4.4)
Build: Firefox for Android 35.0a1 (02-10-2014)

Steps to reproduce:
1. Go to: http://mozilla.github.io/webrtc-landing/gum_test.html
2. Choose Video
3. Choose share from the doorhanger notification

Expected result:
- A video should appear with the built-in camera active showing the content from my camera.

Actual result:
- "Starting video failed" is displayed

May be bug 1074202 the cause?

Comment 1

[Aaron Train [:aaronmt]]

I see W/GeckoEventDispatcher( 6810): No listeners for MediaPlayer:Get

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #1)
> I see W/GeckoEventDispatcher( 6810): No listeners for MediaPlayer:Get

That is Chromecast related and should not be related to this issue. This is probably happening because we are delaying the MediaPlayerManager loading for performance reasons. Again, should not be related to this bug.

Comment 3

[Aaron Train [:aaronmt]]

Last good revision: 124797ab4a5c
First bad revision: a1d7b16101c7
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=124797ab4a5c&tochange=a1d7b16101c7

[e-mail]
Wed Oct 01 16:43:41 2014 +0000	a1d7b16101c7	Wes Johnston — Bug 1064669 - Initialize MediaPlayers in delayed startup. r=mfinkle

Comment 4

[Gian-Carlo Pascutto [:gcp]]

I'll investigate closer what's really up here.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

E/WEBRTC-JC(13864): startCapture failed
E/WEBRTC-JC(13864): java.lang.IllegalThreadStateException: Expected thread 1 ("main"), but running on thread 483 ("Thread-483")
E/WEBRTC-JC(13864):     at org.mozilla.gecko.util.ThreadUtils.assertOnThreadComparison(ThreadUtils.java:171)
E/WEBRTC-JC(13864):     at org.mozilla.gecko.util.ThreadUtils.assertOnUiThread(ThreadUtils.java:116)
E/WEBRTC-JC(13864):     at org.mozilla.gecko.GeckoApp.addAppStateListener(GeckoApp.java:250)
E/WEBRTC-JC(13864):     at org.webrtc.videoengine.VideoCaptureAndroid.startCapture(VideoCaptureAndroid.java:210)
E/WEBRTC-JC(13864):     at dalvik.system.NativeStart.run(Native Method)
D/WEBRTC-JC(13864): stopCapture

Comment 6

[Gian-Carlo Pascutto [:gcp]]

(In reply to Aaron Train [:aaronmt] from comment #3)

> Wed Oct 01 16:43:41 2014 +0000	a1d7b16101c7	Wes Johnston — Bug 1064669 -
> Initialize MediaPlayers in delayed startup. r=mfinkle

This is indeed the bug that caused it, the patch for it is simply completely broken.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Attachment: backout-a1d7b16101c7

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Backed out, see 1064669.

Comment 9

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 35 Beta 1 with Nexus 4 (Android 4.4.4).

Comment 10

[Stefan Deiac]

Based on comment 9, I will remove the qe-verify flag, thanks.