Fix license headers for some WebRTC files, and provide LICENSE file

RESOLVED FIXED in Firefox 41

Status

()

Core
WebRTC
P2
normal
Rank:
26
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: gerv, Assigned: gerv)

Tracking

unspecified
mozilla41
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The following files:

media/webrtc/signaling/src/media-conduit/VideoTypes.h
media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h

have both an MPLed header and a WebRTC project header. That seems unnecessary. If the code came from the WebRTC project and we've modified it, we should put our modifications under the WebRTC license.

Also, those two files and this file:

media/webrtc/signaling/signaling.gyp

all say:

 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree.

However, there is no such file in media/webrtc/signaling or media/webrtc. We should provide one containing the WebRTC BSD license from here:
http://www.webrtc.org/license-rights/license

Gerv

Updated

4 years ago
Assignee: nobody → rjesup
:jesup: ping?

Gerv
Rank: 26
Priority: -- → P2
Created attachment 8602749 [details] [diff] [review]
Patch v.1
Assignee: rjesup → gerv
Status: NEW → ASSIGNED
Attachment #8602749 - Flags: review?(rjesup)
Comment on attachment 8602749 [details] [diff] [review]
Patch v.1

Review of attachment 8602749 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but to avoid confusion with LICENSE in a non-webrtc.org directory, can we instead do this:

// These constants are picked from WebRTC Implementation. Copyright from the same is
// given below.  LICENSE and AUTHORS can be found in media/webrtc/trunk
Attachment #8602749 - Flags: review?(rjesup) → review+
(In reply to Randell Jesup [:jesup] from comment #3)
> r+, but to avoid confusion with LICENSE in a non-webrtc.org directory, can
> we instead do this:
> 
> // These constants are picked from WebRTC Implementation. Copyright from the
> same is
> // given below.  LICENSE and AUTHORS can be found in media/webrtc/trunk

The trouble with that is that my license scanner knows how to scan a directory and its parents for a file referenced in a header, but it doesn't know how to read English :-| I could teach it a special exception, but that seems overkill for two files. 

If you would prefer, we could just add the LICENSE text direct to the header of the two files, instead of the current header text.

Gerv
Flags: needinfo?(rjesup)
(In reply to Gervase Markham [:gerv] from comment #4)
> (In reply to Randell Jesup [:jesup] from comment #3)
> > r+, but to avoid confusion with LICENSE in a non-webrtc.org directory, can
> > we instead do this:
> > 
> > // These constants are picked from WebRTC Implementation. Copyright from the
> > same is
> > // given below.  LICENSE and AUTHORS can be found in media/webrtc/trunk
> 
> The trouble with that is that my license scanner knows how to scan a
> directory and its parents for a file referenced in a header, but it doesn't
> know how to read English :-| I could teach it a special exception, but that
> seems overkill for two files. 

We need to get to work on that!  We can understand spoken english, after all, with WebSpeech! ;-)

> If you would prefer, we could just add the LICENSE text direct to the header
> of the two files, instead of the current header text.

I think this would be preferable, thanks.  r=jesup
Flags: needinfo?(rjesup)

Updated

3 years ago
backlog: --- → webRTC+
Created attachment 8607068 [details] [diff] [review]
Patch v.2

As requested.

Gerv
Attachment #8602749 - Attachment is obsolete: true
Attachment #8607068 - Flags: review?(rjesup)

Updated

3 years ago
Attachment #8607068 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/580e0c9bb03f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.