1076906 - Fix license headers for some WebRTC files, and provide LICENSE file

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Gervase Markham [:gerv]]

The following files:

media/webrtc/signaling/src/media-conduit/VideoTypes.h
media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.h

have both an MPLed header and a WebRTC project header. That seems unnecessary. If the code came from the WebRTC project and we've modified it, we should put our modifications under the WebRTC license.

Also, those two files and this file:

media/webrtc/signaling/signaling.gyp

all say:

 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree.

However, there is no such file in media/webrtc/signaling or media/webrtc. We should provide one containing the WebRTC BSD license from here:
http://www.webrtc.org/license-rights/license

Gerv

Comment 1

[Gervase Markham [:gerv]]

:jesup: ping?

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8602749 [details] [diff] [review]
Patch v.1

Review of attachment 8602749 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but to avoid confusion with LICENSE in a non-webrtc.org directory, can we instead do this:

// These constants are picked from WebRTC Implementation. Copyright from the same is
// given below.  LICENSE and AUTHORS can be found in media/webrtc/trunk

Comment 4

[Gervase Markham [:gerv]]

(In reply to Randell Jesup [:jesup] from comment #3)
> r+, but to avoid confusion with LICENSE in a non-webrtc.org directory, can
> we instead do this:
> 
> // These constants are picked from WebRTC Implementation. Copyright from the
> same is
> // given below.  LICENSE and AUTHORS can be found in media/webrtc/trunk

The trouble with that is that my license scanner knows how to scan a directory and its parents for a file referenced in a header, but it doesn't know how to read English :-| I could teach it a special exception, but that seems overkill for two files. 

If you would prefer, we could just add the LICENSE text direct to the header of the two files, instead of the current header text.

Gerv

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Gervase Markham [:gerv] from comment #4)
> (In reply to Randell Jesup [:jesup] from comment #3)
> > r+, but to avoid confusion with LICENSE in a non-webrtc.org directory, can
> > we instead do this:
> > 
> > // These constants are picked from WebRTC Implementation. Copyright from the
> > same is
> > // given below.  LICENSE and AUTHORS can be found in media/webrtc/trunk
> 
> The trouble with that is that my license scanner knows how to scan a
> directory and its parents for a file referenced in a header, but it doesn't
> know how to read English :-| I could teach it a special exception, but that
> seems overkill for two files. 

We need to get to work on that!  We can understand spoken english, after all, with WebSpeech! ;-)

> If you would prefer, we could just add the LICENSE text direct to the header
> of the two files, instead of the current header text.

I think this would be preferable, thanks.  r=jesup

Comment 6

[Gervase Markham [:gerv]]

Attachment: Patch v.2

As requested.

Gerv

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/580e0c9bb03f

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/580e0c9bb03f

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/580e0c9bb03f