Closed Bug 1076986 Opened 9 years ago Closed 9 years ago

Make LogicalMargin and LogicalRect's IsEmpty have the same semantic as the base classes

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

Attachments

(1 file)

is.empty.diff
3.46 KB, patch
jfkthame
: review+
Details | Diff | Splinter Review
Attached patch is.empty.diff — — Splinter Review 
Back in bug 789096 I added an IsEmpty shorthand to LogicalMargin and LogicalRect. What I didn't notice is that nsMargin and nsRect already have an IsEmpty, and the semantic is different.

This is the cause of some of the bugs in my w-i-p patch for bug 1062963.
Attachment #8498994 - Flags: review?(jfkthame)
Assignee: nobody → smontagu
Attachment #8498994 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/e2ae0efd508a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.