Closed Bug 1076986 Opened 5 years ago Closed 5 years ago

Make LogicalMargin and LogicalRect's IsEmpty have the same semantic as the base classes

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: smontagu, Assigned: smontagu)

References

Details

Attachments

(1 file)

Attached patch is.empty.diffSplinter Review
Back in bug 789096 I added an IsEmpty shorthand to LogicalMargin and LogicalRect. What I didn't notice is that nsMargin and nsRect already have an IsEmpty, and the semantic is different.

This is the cause of some of the bugs in my w-i-p patch for bug 1062963.
Attachment #8498994 - Flags: review?(jfkthame)
Assignee: nobody → smontagu
Attachment #8498994 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/e2ae0efd508a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.