Closed
Bug 1076986
Opened 10 years ago
Closed 10 years ago
Make LogicalMargin and LogicalRect's IsEmpty have the same semantic as the base classes
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
Attachments
(1 file)
|
3.46 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
Back in bug 789096 I added an IsEmpty shorthand to LogicalMargin and LogicalRect. What I didn't notice is that nsMargin and nsRect already have an IsEmpty, and the semantic is different.
This is the cause of some of the bugs in my w-i-p patch for bug 1062963.
Attachment #8498994 -
Flags: review?(jfkthame)
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → smontagu
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Attachment #8498994 -
Flags: review?(jfkthame) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Flags: in-testsuite-
|
||
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•