1077080 - submit button states in about:feedback

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivek Balakrishnan[:vivek]]

This is a follow up bug for #1007436

While giving negative feedback, Submit button should be in disabled state when there are no valid text in textbox.

Comment 1

[Vivek Balakrishnan[:vivek]]

Attachment: 1077080.patch

Patch to handle button states

Mock available at 
https://drive.google.com/folderview?id=0B34Nogao7VfpSENocE5veG1wTms&usp=sharing

Comment 2

[:Margaret Leibovic]

Comment on attachment 8502856 [details] [diff] [review]
1077080.patch

Review of attachment 8502856 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/themes/core/aboutFeedback.css
@@ +189,5 @@
>    color: #fff;
>  }
>  
> +.description:invalid ~ .send-feedback {
> +  background-color: #8698A8;

Does this pseduo-class apply before the user tries to submit an invalid form?

I think it might be clearer to just enable/disable the submit button, then style those enabled/disabled states.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8502856 [details] [diff] [review]
1077080.patch

Review of attachment 8502856 [details] [diff] [review]:
-----------------------------------------------------------------

After talking to vivek on IRC, I think this approach is fine.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8502856 [details] [diff] [review]
1077080.patch

i feel like the tip in the last step is a bit unnecessary but otherwise, looks good!

Comment 5

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #4)

> i feel like the tip in the last step is a bit unnecessary but otherwise,
> looks good!

That popup is our default form validation popup, so that's part of the platform.

Comment 6

[Carsten Book [:Tomcat]]

Hi,

seems this patch didn't apply cleanly like:

patching file mobile/android/themes/core/aboutFeedback.css
Hunk #1 FAILED at 178
1 out of 1 hunks FAILED -- saving rejects to file mobile/android/themes/core/aboutFeedback.css.rej

Comment 7

[Vivek Balakrishnan[:vivek]]

Attachment: 1077080.patch

A new patch based on latest tree.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/7310cc81927e

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7310cc81927e

Comment 10

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android Nightly 37.0a1 (2014-12-10) and Firefox for Android Aurora 36.0a2 (2014-12-10).
Device: Nexus 4 (Android 4.4.4)