Closed
Bug 1077097
Opened 10 years ago
Closed 10 years ago
Update Bookmarks.jsm API to be coherent with History.jsm
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
12.76 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
The scope of this part is to make this API more coherent with History.jsm input will also accept URL objects, output will always contain URL objects. dates will always be Date objects. update and remove will now take an optional callback and resolve to a bool. While this may look strange for update, since it acts on a single item, it will allow us to make it batch multiple updates in future, without touching the API signature. on invalid input, all methods will throw immediately rather than rejecting later.
Assignee | ||
Comment 1•10 years ago
|
||
Marco, I splitted out this requirement for bug 1068009.
Flags: needinfo?(mmucci)
Comment 3•10 years ago
|
||
Comment on attachment 8499142 [details] [diff] [review] patch v1 uri->url everywhere, as discussed.
Attachment #8499142 -
Flags: review?(mano) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/116b905fd605
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/116b905fd605
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•