Closed
Bug 1077139
Opened 10 years ago
Closed 10 years ago
Use the proper (horizontal i-beam) cursor over vertical-direction text elements
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jfkthame, Assigned: jfkthame)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
2.08 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
This seems to make for a better user experience with vertical text.
Attachment #8499191 -
Flags: review?(dbaron)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8499191 [details] [diff] [review] Use the vertical-text IBeam cursor when the writing mode is vertical. Review of attachment 8499191 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsTextFrame.cpp @@ +4220,5 @@ > nsIFrame::Cursor& aCursor) > { > FillCursorInformationFromStyle(StyleUserInterface(), aCursor); > if (NS_STYLE_CURSOR_AUTO == aCursor.mCursor) { > + aCursor.mCursor = GetWritingMode().IsVertical() ? oops, let's lose the trailing whitespace
Comment on attachment 8499191 [details] [diff] [review] Use the vertical-text IBeam cursor when the writing mode is vertical. r=dbaron (Am I the only one who prefers the : and ? at the start of the line, lined up with each other?)
Attachment #8499191 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) from comment #3) > Comment on attachment 8499191 [details] [diff] [review] > Use the vertical-text IBeam cursor when the writing mode is vertical. > > r=dbaron > > (Am I the only one who prefers the : and ? at the start of the line, lined > up with each other?) No; I think I prefer that, too. Turns out the style guide was changed (5 years ago!) on this issue; I was obeying a long-obsolete rule. I'll fix it before landing, and try to change my old habit.
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/795d9067f6c6
Target Milestone: --- → mozilla35
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/795d9067f6c6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•