1077139 - Use the proper (horizontal i-beam) cursor over vertical-direction text elements

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Use the vertical-text IBeam cursor when the writing mode is vertical.

This seems to make for a better user experience with vertical text.

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 8499191 [details] [diff] [review]
Use the vertical-text IBeam cursor when the writing mode is vertical.

Review of attachment 8499191 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsTextFrame.cpp
@@ +4220,5 @@
>                         nsIFrame::Cursor& aCursor)
>  {
>    FillCursorInformationFromStyle(StyleUserInterface(), aCursor);  
>    if (NS_STYLE_CURSOR_AUTO == aCursor.mCursor) {
> +    aCursor.mCursor = GetWritingMode().IsVertical() ? 

oops, let's lose the trailing whitespace

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8499191 [details] [diff] [review]
Use the vertical-text IBeam cursor when the writing mode is vertical.

r=dbaron

(Am I the only one who prefers the : and ? at the start of the line, lined up with each other?)

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) from comment #3)
> Comment on attachment 8499191 [details] [diff] [review]
> Use the vertical-text IBeam cursor when the writing mode is vertical.
> 
> r=dbaron
> 
> (Am I the only one who prefers the : and ? at the start of the line, lined
> up with each other?)

No; I think I prefer that, too.

Turns out the style guide was changed (5 years ago!) on this issue; I was obeying a long-obsolete rule. I'll fix it before landing, and try to change my old habit.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/795d9067f6c6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/795d9067f6c6