1077245 - Titlebar buttons are missing with WindowBlinds theme installed

Status: NEW

(Core :: Graphics: Layers, defect, P3)

Description

[Mike]

Attachment: titlebar.png with Windowsblinds loaded

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141002004001

Steps to reproduce:

Install Windowblinds
select any theme



Actual results:

Minimize, restore, and close buttons are gone. 
titlebar is all black with the exception of the tab and add new tab button


Expected results:

Aurora should have been skinned and buttons still visible

Comment 1

[Loic]

If you test FF32 or 33, do you see the same issue?

Comment 2

[Mike]

It happens with FF32, 32.0.3 it happens with.  I'll download 33 and see.  also I can use the recursive check tool thing again and see what I get.

Comment 3

[Mike]

Correction, It goes aqay in FF32, 33.0.3 if I use a different windowblinds theme, or at least mostly.  I don't see how to add another attachment or I can upload what I am seeing.

Comment 4

[Loic]

Which themes of WindowBlinds are problematic with FF33 and FF34?

Comment 5

[Mike]

I ran a regression test and log should be here:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bb8fc1380b00tochange=46d9ffb97fe3

The these I was using was, Arsenic 8, Corporate UI, Win 8 theme has the issue as well.  I can test more but it seems many of theme do.  The regression test I ran had it in some versions but not others.

Comment 6

[Loic]

Thanks for the regression range but the pushlog seems to be empty.
Did you run Mozreg with mozillacentral (m-c) as repo?

Comment 7

[Mike]

no, just ran it as --bits=32.  Which repo do I specify?

mozregression --bits=32 --repo=??????

Thanks,

Comment 8

[Loic]

mozregression --good=2014-06-01 is enough to find a reg range.

Comment 9

[Mike]

No more inbounds to bisect
Last good revision: bb8fc1380b00
First bad revision: 46d9ffb97fe3
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bb8fc1
380b00&tochange=46d9ffb97fe3


It looks to me like there is a transparency being set on the title bar that goes all the way across and "hides" the buttons.  Any good regression is not transparent, the bad ones are transparent.

Comment 10

[Loic]

Thanks.

Comment 11

[Loic]

Bug 899785 has landed in FF32, so it's strange you don't get the issue in FF32 too.

Comment 12

[Rudolf]

Attachment: Mozilla_Title_TB.png

I have the same issue in Windows 8.1, WITHOUT using WindowsBlinds.
It can be recreated with "Thunderbird 31.2.0" and "Firefox 33.0".
See attached screenshot: Mozilla_Title_TB.png

Recreation scenario:
* Use Windows 8.1 Pro with RemoteDeskop enabled (Computer1)
* Computer1: Launch Firefox or Thunderbird
  (Window in normal size, application in foreground)
* Computer1: Lock Screen (to enable remote connection)
* From another computer (Computer2):
  establish a remote desktop connection
* Computer2: Launched application (Firefox/Thunderbird)
  is shown in the way it was started, but has the following...

Symptoms:
* Titlebar is black (as shown in screenshot)
* Doubleclick on titlebar maximizes the window (normal behavior)
* Minimize/Maximize/Close-buttons are not visible (also black)
* Clicking on the location of the Close-button does nothing
* Doubleclick on the location of the Close-button maximizes the window
* If maximized the titlebar is no longer black, but transparent
* The problem does not disappear if disconnecing from Computer1
  and working on the original computer.
* The application works normally in other ways,
  but requires to be restarted to solve the titlebar-issue.

(appears to me, as if a brush-handle is no longer valid)

Comment 13

[Loic]

Rudolf, this bug is about WindowBlinds, file a new bug report, please, even if yours is probably bug 656891.

Comment 14

[Mike]

I just wanted to add to this.  I can click where the buttons are supposed to be and they still function, but the title-bar transparency is still hiding them.

Comment 15

[Loic]

Mike, FF33 has been updated to FF33.0.1 to fix bug 1083071 about OMTC introduced in FF33.

Could you update to 33.0.1 and test if your issue with WindowBlinds is still present.

If that's the case, go to about:config and change layers.offmainthreadcomposition.enabled to false (restart FF to apply) and test again.

Comment 16

[Mike]

Linked are 2 files, one with layers.offmainthreadcomposition.enabled "true":

https://db.tt/CZ9RF7W5

one with layers.offmainthreadcomposition.enabled  "false":

https://db.tt/83YSCwZB

Comment 17

[Milan Sreckovic [:milan] (needinfo for best results)]

Bas, looks related to the other places where minimize/etc. buttons disappear on high aspect ratio windows?

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

we're too late in the 35 cycle to take anything speculative so this will have to remain in the shipping builds for at least one more round.

Comment 19

[Sylvestre Ledru [:Sylvestre]]

No activity, we shipped several releases with this bug. I am not sure it is worth tracking anymore...

Comment 20

[No Real Name, Thanks]

Tried with Nightly, the issue is still there.
Changing WindowBlinds options (even specifying per-app rules NOT to theme the .exe) have no effect.

(Meanwhile, Chrome just works. Ehh.)

Comment 21

[No Real Name, Thanks]

Another bit of info, Thunderbird [31.4.0] works with the same theme, same machine, same everything.

Comment 22

[No Real Name, Thanks]

Working workaround can be found here (bottom post):
http://forums.stardock.com/454139

Kudos to Zoticos, shame on Mozilla. First the CEO, now the browser.

Comment 23

[u279076]

Looks like bug 1217547 is a DUPE and from there it looks like this might be a WONTFIX.

Comment 24

[u279076]

The work around as noted in comment 21 is here:
http://forums.stardock.com/454139/get;3505978

I'm not sure if this is still an issue with the latest WindowBlinds. Nearly two years out it doesn't seem like something we're likely to work around in our code.

Milan, what do you think?

Comment 25

[Milan Sreckovic [:milan] (needinfo for best results)]

Is this problem still around?  There were WindowsBlinds problems Stardock Software fixed in 8.11 beta (April 2015), and the last user comment in this bug is January 2015.

Comment 26

[u279076]

(In reply to Milan Sreckovic [:milan] from comment #25)
> Is this problem still around?  There were WindowsBlinds problems Stardock
> Software fixed in 8.11 beta (April 2015), and the last user comment in this
> bug is January 2015.

That I don't know. It would be good if someone who was able to reproduce this earlier could confirm whether it still happens in the latest version.

Comment 27

[Rudolf]

I did not have this problem with Windows Blinds,
but when using a Remote Desktop Connection (see bug 1098499).

Using Remote-Desktop on Windows 10 I cannot reproduce the problem any more. Nice!
Maybe the fix applies to Windows Blinds as well.

Comment 28

[Loic]

Mike, do you still have the issue with the latest version of Firefox and WindowsBlinds?

Comment 29

[lwhite]

Attachment: Titlebar issues with windowsblinds

This might need a new bug report but I feel it's still kind of related so I'm going to post it here.  The Titlebar icons appear but they don't work at all (even clicking outside of where they are visible) as if they don't actually exist.  The menus when enabled are a bit messed up offset wise, but at least they still work.

Comment 30

[Gregory Pappas [:gregp]]

Reporter, are you still experiencing this issue?