Closed Bug 1077268 Opened 6 years ago Closed 6 years ago

Make app update tests use the GreBinD dir service key implemented in bug 1077099

Categories

(Toolkit :: Application Update, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 2 obsolete files)

This will clean things up a bit and make the code more correct.
Depends on: 1077099
Attached patch patch rev1 (obsolete) — Splinter Review
Attachment #8499342 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8499342 [details] [diff] [review]
patch rev1

Found a problem with this too!
Attachment #8499342 - Flags: review?(spohl.mozilla.bugs)
Attached patch patch (obsolete) — Splinter Review
Attachment #8499342 - Attachment is obsolete: true
Attachment #8503028 - Flags: review?(spohl.mozilla.bugs)
Pushed to try along with the followup patch from bug 1077099 just in case
https://tbpl.mozilla.org/?tree=Try&rev=395908b9bb28
Comment on attachment 8503028 [details] [diff] [review]
patch

Review of attachment 8503028 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you! r=spohl with comments below addressed or answered.

::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
@@ +1137,2 @@
>    }
>    if (!iniFile.exists()) {

nit: we could move this second check into the first one above to match what we're doing in |runUpdate|. No need to do this if the second comment below was intentional and you wouldn't already have to refresh the patch.

@@ +1843,4 @@
>    let shouldSymlink = (pathParts[pathParts.length - 1] == "XUL" ||
>                         fileRelPath.substr(fileRelPath.length - 3) == ".so" ||
>                         fileRelPath.substr(fileRelPath.length - 6) == ".dylib");
> +  shouldSymlink = false;

I'm assuming you set |shouldSymlink| to |false| unconditionally for debugging? If this is meant to stay this way, can we do away with the |shouldSymlink| check all together?
Attachment #8503028 - Flags: review?(spohl.mozilla.bugs) → review+
Attachment #8503028 - Attachment is obsolete: true
Attachment #8503123 - Flags: review+
Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/311c125897e5
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/311c125897e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.