Closed
Bug 1077268
Opened 10 years ago
Closed 10 years ago
Make app update tests use the GreBinD dir service key implemented in bug 1077099
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 2 obsolete files)
24.67 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
This will clean things up a bit and make the code more correct.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8499342 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Comment 2•10 years ago
|
||
Try was locked up so I pushed to oak https://hg.mozilla.org/projects/oak/rev/2469404b228d
Assignee | ||
Comment 3•10 years ago
|
||
Test results can be seen here https://tbpl.mozilla.org/?tree=Oak&rev=7d0ccd91e8db
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8499342 [details] [diff] [review] patch rev1 Found a problem with this too!
Attachment #8499342 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8499342 -
Attachment is obsolete: true
Attachment #8503028 -
Flags: review?(spohl.mozilla.bugs)
Assignee | ||
Comment 6•10 years ago
|
||
Pushed to try along with the followup patch from bug 1077099 just in case https://tbpl.mozilla.org/?tree=Try&rev=395908b9bb28
Comment 7•10 years ago
|
||
Comment on attachment 8503028 [details] [diff] [review] patch Review of attachment 8503028 [details] [diff] [review]: ----------------------------------------------------------------- Thank you! r=spohl with comments below addressed or answered. ::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js @@ +1137,2 @@ > } > if (!iniFile.exists()) { nit: we could move this second check into the first one above to match what we're doing in |runUpdate|. No need to do this if the second comment below was intentional and you wouldn't already have to refresh the patch. @@ +1843,4 @@ > let shouldSymlink = (pathParts[pathParts.length - 1] == "XUL" || > fileRelPath.substr(fileRelPath.length - 3) == ".so" || > fileRelPath.substr(fileRelPath.length - 6) == ".dylib"); > + shouldSymlink = false; I'm assuming you set |shouldSymlink| to |false| unconditionally for debugging? If this is meant to stay this way, can we do away with the |shouldSymlink| check all together?
Attachment #8503028 -
Flags: review?(spohl.mozilla.bugs) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8503028 -
Attachment is obsolete: true
Attachment #8503123 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Pushed to mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/311c125897e5
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/311c125897e5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•10 years ago
|
||
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•