1077268 - Make app update tests use the GreBinD dir service key implemented in bug 1077099

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

This will clean things up a bit and make the code more correct.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 2

[Robert Strong (they/them - no direct email)]

Try was locked up so I pushed to oak
https://hg.mozilla.org/projects/oak/rev/2469404b228d

Comment 3

[Robert Strong (they/them - no direct email)]

Test results can be seen here
https://tbpl.mozilla.org/?tree=Oak&rev=7d0ccd91e8db

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8499342 [details] [diff] [review]
patch rev1

Found a problem with this too!

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to try along with the followup patch from bug 1077099 just in case
https://tbpl.mozilla.org/?tree=Try&rev=395908b9bb28

Comment 7

[Stephen A Pohl [:spohl]]

Comment on attachment 8503028 [details] [diff] [review]
patch

Review of attachment 8503028 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you! r=spohl with comments below addressed or answered.

::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
@@ +1137,2 @@
>    }
>    if (!iniFile.exists()) {

nit: we could move this second check into the first one above to match what we're doing in |runUpdate|. No need to do this if the second comment below was intentional and you wouldn't already have to refresh the patch.

@@ +1843,4 @@
>    let shouldSymlink = (pathParts[pathParts.length - 1] == "XUL" ||
>                         fileRelPath.substr(fileRelPath.length - 3) == ".so" ||
>                         fileRelPath.substr(fileRelPath.length - 6) == ".dylib");
> +  shouldSymlink = false;

I'm assuming you set |shouldSymlink| to |false| unconditionally for debugging? If this is meant to stay this way, can we do away with the |shouldSymlink| check all together?

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: Patch - updated to comments

Comment 9

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/311c125897e5

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/311c125897e5

Comment 11

[Robert Strong (they/them - no direct email)]

Landed on aurora in the Mac V2 signing combined patch in bug 1047584