Closed
Bug 1077307
Opened 10 years ago
Closed 10 years ago
Remove NewTextureSource
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: nical, Assigned: nical)
Details
Attachments
(1 file, 1 obsolete file)
31.02 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
NewTextureSource was introduced to facilitate the transition to the new TextureClients/Hosts, and should have long been removed, but I forgot about it. It should be trivial to do now (merge it with the TextureSource class).
Assignee | ||
Comment 1•10 years ago
|
||
A simple copy-paste of NewTextureSource's methods into TextureSource + a sed script did the job.
Assignee: nobody → nical.bugzilla
Attachment #8500557 -
Flags: review?(sotaro.ikeda.g)
Assignee | ||
Comment 2•10 years ago
|
||
try push https://tbpl.mozilla.org/?tree=Try&rev=f187a43c077a
Comment 3•10 years ago
|
||
Nice. And you are removing TextureSource, not NewTextureSource. You are just renaming at the same time.
Comment 4•10 years ago
|
||
Comment on attachment 8500557 [details] [diff] [review] Merge NewTextureSource and TextureSource Review of attachment 8500557 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/composite/TextureHost.h @@ +648,4 @@ > { > public: > + NS_INLINE_DECL_REFCOUNTING(TextureSource) > + Why is it necessary? Ancestor class(TextureSource) is already refcounted class.
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #4) > Why is it necessary? Ancestor class(TextureSource) is already refcounted > class. That's a mistake, good catch.
Assignee | ||
Comment 6•10 years ago
|
||
fixes the bogus NS_INLINE_DECL_REFCOUNING
Attachment #8500557 -
Attachment is obsolete: true
Attachment #8500557 -
Flags: review?(sotaro.ikeda.g)
Attachment #8500765 -
Flags: review?(sotaro.ikeda.g)
Updated•10 years ago
|
Attachment #8500765 -
Flags: review?(sotaro.ikeda.g) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6cf5c560a2f
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b6cf5c560a2f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•