1077307 - Remove NewTextureSource

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

NewTextureSource was introduced to facilitate the transition to the new TextureClients/Hosts, and should have long been removed, but I forgot about it. It should be trivial to do now (merge it with the TextureSource class).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Merge NewTextureSource and TextureSource

A simple copy-paste of NewTextureSource's methods into TextureSource + a sed script did the job.

Comment 2

[Nicolas Silva [:nical]]

try push https://tbpl.mozilla.org/?tree=Try&rev=f187a43c077a

Comment 3

[Andreas Gal :gal]

Nice. And you are removing TextureSource, not NewTextureSource. You are just renaming at the same time.

Comment 4

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8500557 [details] [diff] [review]
Merge NewTextureSource and TextureSource

Review of attachment 8500557 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/TextureHost.h
@@ +648,4 @@
>  {
>  public:
> +  NS_INLINE_DECL_REFCOUNTING(TextureSource)
> +

Why is it necessary? Ancestor class(TextureSource) is already refcounted class.

Comment 5

[Nicolas Silva [:nical]]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> Why is it necessary? Ancestor class(TextureSource) is already refcounted
> class.

That's a mistake, good catch.

Comment 6

[Nicolas Silva [:nical]]

Attachment: Merge NewTextureSource and TextureSource

fixes the bogus NS_INLINE_DECL_REFCOUNING

Comment 7

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6cf5c560a2f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b6cf5c560a2f