Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla35
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

NewTextureSource was introduced to facilitate the transition to the new TextureClients/Hosts, and should have long been removed, but I forgot about it. It should be trivial to do now (merge it with the TextureSource class).
A simple copy-paste of NewTextureSource's methods into TextureSource + a sed script did the job.
Assignee: nobody → nical.bugzilla
Attachment #8500557 - Flags: review?(sotaro.ikeda.g)
Nice. And you are removing TextureSource, not NewTextureSource. You are just renaming at the same time.
Comment on attachment 8500557 [details] [diff] [review]
Merge NewTextureSource and TextureSource

Review of attachment 8500557 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/TextureHost.h
@@ +648,4 @@
>  {
>  public:
> +  NS_INLINE_DECL_REFCOUNTING(TextureSource)
> +

Why is it necessary? Ancestor class(TextureSource) is already refcounted class.
(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> Why is it necessary? Ancestor class(TextureSource) is already refcounted
> class.

That's a mistake, good catch.
fixes the bogus NS_INLINE_DECL_REFCOUNING
Attachment #8500557 - Attachment is obsolete: true
Attachment #8500557 - Flags: review?(sotaro.ikeda.g)
Attachment #8500765 - Flags: review?(sotaro.ikeda.g)
Attachment #8500765 - Flags: review?(sotaro.ikeda.g) → review+
https://hg.mozilla.org/mozilla-central/rev/b6cf5c560a2f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.