Rename ScalarValueString to USVString

RESOLVED FIXED in mozilla36

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: annevk, Assigned: baku, Mentored)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla36
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=python], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
heycam picked a different name from me when he uplifted my proposal into IDL. I'm assuming this is it now.
Mentor: bzbarsky
Whiteboard: [lang=python]
This bug is all about changing the name from ScalarValueString to USVString at all places.

Updated

4 years ago
Flags: needinfo?(bzbarsky)
What information are you looking for?
Flags: needinfo?(bzbarsky) → needinfo?(akshendra521994)
Sorry I messed up the needinfo, I asked about that in comment 1.
I wanted to know is this bug all about, renaming the occurances of ScalarValueString to USVString?
Flags: needinfo?(akshendra521994)
Yes, exactly.  Comment 1 wasn't a question.... ;)
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 5

4 years ago
Created attachment 8526054 [details] [diff] [review]
svs.patch

https://tbpl.mozilla.org/?tree=Try&rev=2ecadd751073

Just a bit more than: %s/ScalarValueString/USVString/g
Attachment #8526054 - Flags: review?(bugs)
(Assignee)

Updated

4 years ago
Assignee: nobody → amarchesini

Comment 6

4 years ago
Comment on attachment 8526054 [details] [diff] [review]
svs.patch

>diff --git a/dom/bindings/test/TestBindingHeader.h b/dom/bindings/test/TestBindingHeader.h
>--- a/dom/bindings/test/TestBindingHeader.h
>+++ b/dom/bindings/test/TestBindingHeader.h
>@@ -475,17 +475,17 @@ public:
> 
>   // ByteString types
>   void PassByteString(const nsCString&);
>   void PassNullableByteString(const nsCString&);
>   void PassOptionalByteString(const Optional<nsCString>&);
>   void PassOptionalNullableByteString(const Optional<nsCString>&);
>   void PassVariadicByteString(const Sequence<nsCString>&);
> 
>-  // ScalarValueString types
>+  // USVString types
>   void PassSVS(const nsAString&);
s/SVS/USV/
tai
s/SVS/USVS/


>-  void PassUnionWithSVS(const ScalarValueStringOrLong&);
>+  void PassUnionWithSVS(const USVStringOrLong&);
ditto

>-  // ScalarValueString types
>-  void passSVS(ScalarValueString arg);
>-  void passNullableSVS(ScalarValueString? arg);
>-  void passOptionalSVS(optional ScalarValueString arg);
>-  void passOptionalSVSWithDefaultValue(optional ScalarValueString arg = "abc");
>-  void passOptionalNullableSVS(optional ScalarValueString? arg);
>-  void passOptionalNullableSVSWithDefaultValue(optional ScalarValueString? arg = null);
>-  void passVariadicSVS(ScalarValueString... arg);
>-  ScalarValueString receiveSVS();
>+  // USVString types
>+  void passSVS(USVString arg);
>+  void passNullableSVS(USVString? arg);
>+  void passOptionalSVS(optional USVString arg);
>+  void passOptionalSVSWithDefaultValue(optional USVString arg = "abc");
>+  void passOptionalNullableSVS(optional USVString? arg);
>+  void passOptionalNullableSVSWithDefaultValue(optional USVString? arg = null);
>+  void passVariadicSVS(USVString... arg);
>+  USVString receiveSVS();
And here


>@@ -573,17 +573,17 @@ interface TestInterface {
>   void passUnion26((sequence<sequence<ImageData?>> or long) arg);
>   void passUnion27(optional (sequence<DOMString> or EventInit) arg);
>   void passUnion28(optional (EventInit or sequence<DOMString>) arg);
>   void passUnionWithCallback((EventHandler or long) arg);
>   void passUnionWithByteString((ByteString or long) arg);
>   void passUnionWithMozMap((MozMap<DOMString> or DOMString) arg);
>   void passUnionWithMozMapAndSequence((MozMap<DOMString> or sequence<DOMString>) arg);
>   void passUnionWithSequenceAndMozMap((sequence<DOMString> or MozMap<DOMString>) arg);
>-  void passUnionWithSVS((ScalarValueString or long) arg);
>+  void passUnionWithSVS((USVString or long) arg);
and here


>-  // ScalarValueString types
>-  void passSVS(ScalarValueString arg);
>-  void passNullableSVS(ScalarValueString? arg);
>-  void passOptionalSVS(optional ScalarValueString arg);
>-  void passOptionalSVSWithDefaultValue(optional ScalarValueString arg = "abc");
>-  void passOptionalNullableSVS(optional ScalarValueString? arg);
>-  void passOptionalNullableSVSWithDefaultValue(optional ScalarValueString? arg = null);
>-  void passVariadicSVS(ScalarValueString... arg);
>-  ScalarValueString receiveSVS();
>+  // USVString types
>+  void passSVS(USVString arg);
>+  void passNullableSVS(USVString? arg);
>+  void passOptionalSVS(optional USVString arg);
>+  void passOptionalSVSWithDefaultValue(optional USVString arg = "abc");
>+  void passOptionalNullableSVS(optional USVString? arg);
>+  void passOptionalNullableSVSWithDefaultValue(optional USVString? arg = null);
>+  void passVariadicSVS(USVString... arg);
>+  USVString receiveSVS();
and here

>   void passOptionalNullableEnumWithDefaultValue(optional TestEnum? arg = null);
>@@ -438,17 +438,17 @@ interface TestExampleInterface {
>   void passUnion26((sequence<sequence<ImageData?>> or long) arg);
>   void passUnion27(optional (sequence<DOMString> or EventInit) arg);
>   void passUnion28(optional (EventInit or sequence<DOMString>) arg);
>   void passUnionWithCallback((EventHandler or long) arg);
>   void passUnionWithByteString((ByteString or long) arg);
>   void passUnionWithMozMap((MozMap<DOMString> or DOMString) arg);
>   void passUnionWithMozMapAndSequence((MozMap<DOMString> or sequence<DOMString>) arg);
>   void passUnionWithSequenceAndMozMap((sequence<DOMString> or MozMap<DOMString>) arg);
>-  void passUnionWithSVS((ScalarValueString or long) arg);
>+  void passUnionWithSVS((USVString or long) arg);
ditto

>-  // ScalarValueString types
>-  void passSVS(ScalarValueString arg);
>-  void passNullableSVS(ScalarValueString? arg);
>-  void passOptionalSVS(optional ScalarValueString arg);
>-  void passOptionalSVSWithDefaultValue(optional ScalarValueString arg = "abc");
>-  void passOptionalNullableSVS(optional ScalarValueString? arg);
>-  void passOptionalNullableSVSWithDefaultValue(optional ScalarValueString? arg = null);
>-  void passVariadicSVS(ScalarValueString... arg);
>-  ScalarValueString receiveSVS();
>+  // USVString types
>+  void passSVS(USVString arg);
>+  void passNullableSVS(USVString? arg);
>+  void passOptionalSVS(optional USVString arg);
>+  void passOptionalSVSWithDefaultValue(optional USVString arg = "abc");
>+  void passOptionalNullableSVS(optional USVString? arg);
>+  void passOptionalNullableSVSWithDefaultValue(optional USVString? arg = null);
>+  void passVariadicSVS(USVString... arg);
>+  USVString receiveSVS();
ditto

>@@ -451,17 +451,17 @@ interface TestJSImplInterface {
>   void passUnion26((sequence<sequence<ImageData?>> or long) arg);
>   void passUnion27(optional (sequence<DOMString> or EventInit) arg);
>   void passUnion28(optional (EventInit or sequence<DOMString>) arg);
>   void passUnionWithCallback((EventHandler or long) arg);
>   void passUnionWithByteString((ByteString or long) arg);
>   void passUnionWithMozMap((MozMap<DOMString> or DOMString) arg);
>   void passUnionWithMozMapAndSequence((MozMap<DOMString> or sequence<DOMString>) arg);
>   void passUnionWithSequenceAndMozMap((sequence<DOMString> or MozMap<DOMString>) arg);
>-  void passUnionWithSVS((ScalarValueString or long) arg);
>+  void passUnionWithSVS((USVString or long) arg);
ditto



(I assume s/SVS/USVS/gsm for the relevant files would do the trick)
Attachment #8526054 - Flags: review?(bugs) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 8526290 [details] [diff] [review]
svs.patch
Attachment #8526054 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/efa7ad01dac6
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
USVString documented here - could perhaps do with a quick tech review

https://developer.mozilla.org/en-US/docs/Web/API/USVString
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.