Closed Bug 1077404 Opened 10 years ago Closed 10 years ago

[Linux] Graphical issues and incorect shape of icons on Panic button menu

Categories

(Firefox :: Toolbars and Customization, defect)

All
Linux
defect
Not set
normal
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 35
Iteration:
35.3
Tracking Status
firefox33 --- verified
firefox34 --- verified
firefox35 --- verified

People

(Reporter: bmaris, Assigned: Gijs)

References

Details

Attachments

(4 files)

STR:
1. Open Aurora.
2. Click the 'Forget' icon.
3. Select a option for 'Forget the last'
4. Hover the cursor over the other options.

Expected results: No graphical issues can be seen and the icons are properly displayed.

Actual results: After hovering over the other options, they all look like they are selected. The circle icons are not round, more like elliptical shape.

Notes:
1. This is Linux only (I used 14.04 32/64bit).
2. Also reproducible in latest Nightly.
3. Screenshot showing the issue: https://db.tt/f7BOJbAA
This fixes both issues. I think we need the alignment everywhere, so I've stuck that in the .inc file. I'll doublecheck that that doesn't regress anything in a bit, although I wouldn't expect so.
Attachment #8500595 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(fine on OS X)
(In reply to :Gijs Kruitbosch from comment #2)
> (fine on OS X)

And Windows.
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #0)
> 3. Screenshot showing the issue: https://db.tt/f7BOJbAA

Changed the directory of the image so the link from above is not working anymore. Here is the correct link: https://db.tt/HO9oMTc6
Attached image Screenshot of bug
Please attach screenshots and screencasts of bugs directly to the bug unless the filesize is too large. Files attached to bugs will live as long as we are using Bugzilla, but external accounts and systems may close over time.
Attachment #8502231 - Attachment is patch: false
Attachment #8502231 - Attachment mime type: text/plain → image/png
Comment on attachment 8500595 [details] [diff] [review]
subviewradio elements in panic button panel are elliptical and labels get borders,

Review of attachment 8500595 [details] [diff] [review]:
-----------------------------------------------------------------

Just applying the -moz-appearance:none fixes it for me. Once that is applied, I don't see any visual change when -moz-box-align:center; is applied.
Attachment #8500595 - Flags: review?(jaws)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> Comment on attachment 8500595 [details] [diff] [review]
> subviewradio elements in panic button panel are elliptical and labels get
> borders,
> 
> Review of attachment 8500595 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Just applying the -moz-appearance:none fixes it for me. Once that is
> applied, I don't see any visual change when -moz-box-align:center; is
> applied.

On Linux, at least, the default box-align is 'stretch'. Whether that causes issues here depends on the font size of the label text next to the radio check. When I looked at this on my Fedora VM, the radio check was 16x18px, so still slightly stretched. I also expect this might cause issues on Windows if people adjust default font sizes. I can investigate more this afternoon.
Comment on attachment 8500595 [details] [diff] [review]
subviewradio elements in panic button panel are elliptical and labels get borders,

Ok, you can land this as-is then. Thanks for the response :)
Attachment #8500595 - Flags: review+
Mumble mumble tree closure. :-(

No try push because CSS only change.
Keywords: checkin-needed
This escaped the 'backlog all the things' dance. :-(
Iteration: --- → 35.3
Points: --- → 1
Flags: qe-verify+
Flags: needinfo?(mmucci)
Flags: in-testsuite-
Flags: firefox-backlog+
Added to IT 35.3
Flags: needinfo?(mmucci)
No longer depends on: Forget-button
https://hg.mozilla.org/mozilla-central/rev/ef3a36ab3ded
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified as fixed using the following environment:

FF 35 he, hu, pa-In, zh-TW, Ko, pt-BR, de, es-ES, fr, ja, pl, ru, fy-Nl, es-CL, fi
Build Id:20141013104757
OS:Ubuntu 14.04 x64, Ubuntu 13.10 x36
Status: RESOLVED → VERIFIED
Comment on attachment 8500595 [details] [diff] [review]
subviewradio elements in panic button panel are elliptical and labels get borders,

Approval Request Comment
[Feature/regressing bug #]: forget button
[User impact if declined]: panel for button looks bad on linux
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: super low
[String/UUID change made/needed]: nope
Attachment #8500595 - Flags: approval-mozilla-beta?
Comment on attachment 8500595 [details] [diff] [review]
subviewradio elements in panic button panel are elliptical and labels get borders,

Beta+
Attachment #8500595 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I was able to reproduce this bug on Aurora 34.0a2 (2014-10-03), using Ubuntu 14.04 x86.

Verified fixed on Ubuntu 14.04 x86 and Ubuntu 12.04 x64 using Beta 34.0b2 (20141020184313) with the following locales: he, hu, pa-In, zh-TW, Ko, pt-BR, de, es-ES, fr, ja, pl, ru, fy-Nl, es-CL, fi.

This fix can be marked as verified.

[bugday-20141022]
Thank you for verifying this! Marking accordingly.
QA Whiteboard: [bugday-20141022]
Also verified that this is fixed using latest alder (2014-10-28) on Ubuntu 14.04 32bit and Ubuntu 12.04 64bit.
You need to log in before you can comment on or make changes to this bug.