Closed
Bug 1077427
Opened 10 years ago
Closed 10 years ago
addRangeAssertions should skip recovered on bailout instructions.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: nbp, Assigned: nbp)
References
Details
Attachments
(1 file)
1.66 KB,
patch
|
sunfish
:
review+
|
Details | Diff | Splinter Review |
Scalar replacement adds Phi for the the arguments of the MObjectState / MArrayState instructions which are captured by the entry resume points. These M*State instructions are some-kind of extensions of the resume points. For an entry resume point, these instructions are stored right after the Phis. As they do not produce any code, the MInterruptCheck is still the first LIR instruction produced. addRangeAssertions add MAssertRange functions and ignores a few instructions such as MInterruptCheck and MBeta. We should also ignore any instruction which is recovered on bailout, as it can be added for the entry resume point.
Assignee | ||
Comment 1•10 years ago
|
||
This should be a quick review ;)
Attachment #8499561 -
Flags: review?(sunfish)
Updated•10 years ago
|
Attachment #8499561 -
Flags: review?(sunfish) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/414bc3c04877
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/414bc3c04877
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•