1077465 - readFromClipboard() |dataLen.value / 2| isn't safe

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Philip Chee]

https://bugzilla.mozilla.org/show_bug.cgi?id=326743#c59

(In reply to Blair McBride [:Unfocused] from comment #55)
> /2 isn't safe. But, you don't need it anyway:
>   searchString = data.toString();

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix

Comment 2

[[e-mail]]

Comment on attachment 8499643 [details] [diff] [review]
Patch v1.0 Proposed fix

>+    var clipboard = Services.clipboard;
Don't do this; if you're going to use Services.clipboard then replace the local variable completely.

>       data = data.value.QueryInterface(Components.interfaces.nsISupportsString);
>-      url = data.data.substring(0, dataLen.value / 2);
>+      url = data.toString();
Stick to data.data, just don't substring it (data.data is slightly more efficient than data.toString() because it's an AString rather than a wstring). (Also applies to the other call site of course.)

Comment 3

[Philip Chee]

Attachment: Patch v2.0 fix review issues.

>>+    var clipboard = Services.clipboard;
> Don't do this;
Reverted this change.

>>       data = data.value.QueryInterface(Components.interfaces.nsISupportsString);
>>-      url = data.data.substring(0, dataLen.value / 2);
>>+      url = data.toString();

> Stick to data.data, just don't substring it (data.data is slightly more 
> efficient than data.toString() because it's an AString rather than a 
> wstring). (Also applies to the other call site of course.)
Fixed.

Comment 4

[[e-mail]]

Comment on attachment 8507532 [details] [diff] [review]
Patch v2.0 fix review issues.

>-    // Create tranferable that will transfer the text.
>+    // Create a tranferable that will transfer the text.
transferable

>       return str.value.QueryInterface(Components.interfaces.nsISupportsString)
>-                .data.substring(0, strLen.value / 2);
>+                .data;
Will this fit on one line?

Comment 5

[Philip Chee]

Pushed to comm-central changeset c3c1bc2ecb51
http://hg.mozilla.org/comm-central/rev/c3c1bc2ecb51