|
46 bytes,
text/x-github-pull-request
|
mai
:
review+
|
Details | Review | Splinter Review |
As part of the user story in Bug 1035553, tapping on an app in the list on the main screen should take the user to an "app detail" view. From the app detail view, the user should be able to view usage specific to that one app. Bug 1035553 will then simply track the addition of a toggle switch to the app detail view to enable/disable cellular data.
|
(Assignee) | |
Updated•3 years ago
|
||
|
|
(Assignee) | |
Comment 1•3 years ago
|
||
Created attachment 8499687 [details] [review] pull-request (master) Marina: I have moved the patch from Bug 1035553 here with the exception of the temporary removal of the toggle switch in the app detail view.
|
|
(Assignee) | |
Comment 2•3 years ago
|
||
Comment on attachment 8499687 [details] [review] pull-request (master) Also adding salva for review on this as well as this patch has been ready for review for over a week now.
|
|
(Assignee) | |
Comment 3•3 years ago
|
||
Comment on attachment 8499687 [details] [review] pull-request (master) Removing salva from review. Spoke to Marina and we will hold off on reviewing/landing this until some remaining v2.1 patches have been landed and uplifted (to prevent having to rebase since this is a fairly large patch).
|
||
Comment 4•3 years ago
|
||
Hi Justin, would you mind rebasing your patch with the latest changes on master? Best regards
|
|
(Assignee) | |
Comment 5•3 years ago
|
||
(In reply to Marina Rodríguez [:mai] from comment #4) > Hi Justin, > would you mind rebasing your patch with the latest changes on master? > Best regards Marina: Done!
|
|
||
Comment 6•3 years ago
|
||
Comment on attachment 8499687 [details] [review] pull-request (master) Nice work. You have a little comment on the PR. Thank you!
|
|
||
Comment 7•3 years ago
|
||
Nowadays, exists a patch to fix the difference between by application breakdown totals and the total by interface (residual traffic). After landing the patch, this difference will be reflected on the system app detail view. This issue must be resolved when the residual traffic was 0. (Bug 1083680 - [Usage][Cost Control] Noticeable difference between by application breakdown totals and the total displayed in chart and widget.)
|
|
(Assignee) | |
Comment 8•3 years ago
|
||
Landed on master: https://github.com/mozilla-b2g/gaia/commit/213352511efa6d41fbfb0b67b023a7d02b428ac4
|
||
Comment 9•3 years ago
|
||
The l10n part doesn't work, we need plurals here :/ Could you open a follow-up to add plural forms for data-used-since, data-used-this-week and data-used-this-month, please? (And update the ID since it has landed)
You'll also need to use two variable instead, like:
data-used-this-week = {{n}} {{unit}} of data used this week
Thanks!|
|
(Assignee) | |
Comment 10•3 years ago
|
||
(In reply to Théo Chevalier [:tchevalier] from comment #9) > The l10n part doesn't work, we need plurals here :/ Could you open a > follow-up to add plural forms for data-used-since, data-used-this-week and > data-used-this-month, please? (And update the ID since it has landed) > > You'll also need to use two variable instead, like: > data-used-this-week = {{n}} {{unit}} of data used this week > > Thanks! Théo: Filed follow-up here: Bug 1088786 Thanks for pointing that out!
Description
•