1077712 - [Flatfish] [Marketplace] Right Side of Marketplace is Cut Off

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Safwan Rahman (:safwan)]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

#Open the Marketplace app in Flatfish Device
# Note at the Right side


Actual results:

Some text of Right site is cut.


Expected results:

All the text of Right side should show properly

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Can you provide a screenshot please?

Comment 2

[Safwan Rahman (:safwan)]

Attachment: screenshot

As a bug of flatfish, can not take screenshot. So upload picture taken by other device

Comment 3

[Safwan Rahman (:safwan)]

Attachment: another picture

Comment 4

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

(In reply to Safwan Rahman from comment #2)
> Created attachment 8499883 [details]
> screenshot
> 
> As a bug of flatfish, can not take screenshot. So upload picture taken by
> other device

If you are on the latest build, you are able to take a screenshot.

Comment 5

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

ni? myself to test and check.

Comment 6

[Safwan Rahman (:safwan)]

(In reply to Andrew Truong [:feer56] from comment #4)
> (In reply to Safwan Rahman from comment #2)
> > Created attachment 8499883 [details]
> > screenshot
> > 
> > As a bug of flatfish, can not take screenshot. So upload picture taken by
> > other device
> 
> If you are on the latest build, you are able to take a screenshot.

Andrew, please see bug 1077702, according to it, screenshot can not be taken in portrait orientation. I am using build of 30th September 2014.

Comment 7

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Attachment: 2014-10-24-22-23-45.png

Unable to reproduce on 20141024 build from vendor. 
closeme?

Comment 8

[Safwan Rahman (:safwan)]

Andrew, can you check the ride side of your screenshot?
If Marketplace app is responsive, the Icon and writing should be seen full!

Comment 10

[Wil Clouser [:clouserw]]

closing based based on comment 7

Comment 11

[Kevin Ngo [:ngoke]]

I will be resolving this soon as a part of https://bugzilla.mozilla.org/show_bug.cgi?id=1092331, which will change our layout library.

Comment 12

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

This is still occurring, however we can track this in the bug mentioned in comment 11

Comment 13

[Christopher Van Wiemeersch [:cvan]]

(In reply to Andrew Truong [:feer56] from comment #12)
> This is still occurring, however we can track this in the bug mentioned in
> comment 11
> 
> *** This bug has been marked as a duplicate of bug 1092331 ***

Seems like an odd way to dupe a bug.

Comment 14

[Safwan Rahman (:safwan)]

(In reply to Wil Clouser [:clouserw] from comment #10)
> closing based based on comment 7

Hi Wil,
Did you read the comments after comment 7? I hope in future you will read all the comments before marking any bug as solved.

Comment 15

[Safwan Rahman (:safwan)]

(In reply to Kevin Ngo [:ngoke] from comment #11)
> I will be resolving this soon as a part of
> https://bugzilla.mozilla.org/show_bug.cgi?id=1092331, which will change our
> layout library.

Hi Kavin, thanks a lot for taking work to make this bug as fixed. As both of the bug is related, I hope this bug should be depend on your mentioned bug 1092331. So as soon as you fix that bug, please let us know here. So that we can verify it and make this bug fixed.

Comment 16

[Safwan Rahman (:safwan)]

(In reply to Andrew Truong [:feer56] from comment #12)
> This is still occurring, however we can track this in the bug mentioned in
> comment 11
> 
> *** This bug has been marked as a duplicate of bug 1092331 ***

Andrew, I think as its not the same case, we can not mark this bug as duplicate. the STR is not same as this one. its a related bug, but not same. As its not related, its not wise to mark this bug as solved.

Comment 17

[Kevin Ngo [:ngoke]]

To update on the progress: https://github.com/mozilla/fireplace/pull/783

Comment 18

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/783

Comment 19

[Kevin Ngo [:ngoke]]

FYI this won't hit production until 11/25.

For now you can test it on https://marketplace-dev.allizom.org or on the Dev app.