1077780 - Perma-failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/settings/test/marionette/tests/root_settings_test.js | check root panel settings sim related tests single sim tests ensure sim security item visible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

1) check root panel settings sim related tests single sim tests ensure sim security item visible:
17:32:22     INFO -    AssertionError: false == true
17:32:22     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/settings/test/marionette/tests/root_settings_test.js:140:16)
17:32:22     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
17:32:22     INFO -        at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
17:32:22     INFO -        at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
17:32:22     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
17:32:22     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
17:32:22     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
17:32:22     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
17:32:22     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
17:32:22     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
17:32:22     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:228:7)
17:32:22     INFO -        at Hook.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
17:32:22     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:258:10)
17:32:22     INFO -        at Object._onImmediate (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:275:5)
17:32:22     INFO -        at processImmediate [as _immediateCallback] (timers.js:330:15)

Comment 1

[Kevin Grandon :kgrandon]

Looks like this started failing somewhere in this merge: https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&jobname=b2g_ubuntu64_vm%20b2g-inbound%20opt%20test%20gaia-integration&rev=5b0c35716c02

Comment 2

[Kevin Grandon :kgrandon]

Example of failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=49542007&tree=B2g-Inbound

Comment 3

[Kevin Grandon :kgrandon]

I am seeing a few new errors in the logs that I have not seen before. I'm wondering if this could be causing the issue:

TypeError: can't redefine non-configurable property 'mozBluetooth'

and also

[marionette error] app://settings.gaiamobile.org/js/utils.js:230 Security wrapper denied access to property 0 on privileged Javascript object. Support for exposing privileged objects to untrusted content via __exposedProps__ is being gradually removed - use WebIDL bindings or Components.utils.cloneInto instead. Note that only the first denied property access from a given global object will be reported.

Comment 4

[Kevin Grandon :kgrandon]

Here is the mock mozBluetooth file we're using: https://github.com/mozilla-b2g/gaia/blob/3209f669cf95966739af382e19a3ccece66efdb0/apps/settings/test/marionette/mocks/mock_navigator_moz_bluetooth.js

Also for the security wrapper problem, it looks like that happens when we call navigator.mozMobileConnections[0].

Comment 5

[Kevin Grandon :kgrandon]

Bobby, Boris - I believe bug 1065185 is causing us to have a few failing tests in gaia. I'm still working out whether or not real functionality is broken, but it could be. Could you guys look through the details in comment 3 and 4 and let me know what you think?

Was navigator.mozMobileConnections[0] expected to break?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Could you guys look through the details in comment 3 and 4 and let me know what you
> think?

Bobby is on PTO.  I can take a look in more detail on Monday, if needed.

Are these tests not enabled by default or something?  :(

> Was navigator.mozMobileConnections[0] expected to break?

Define "expected"?  With the normal implementation, no.

But you're using the mock implementation at https://github.com/mozilla-b2g/gaia/blob/3209f669cf95966739af382e19a3ccece66efdb0/apps/settings/test/marionette/mocks/mock_navigator_moz_mobile_connections_multi.js I assume?  That is totally expected to break: it's returning a chrome-side array object to content code, which is precisely what we're trying to disallow.  You want to change it to:

  var _mobileConnections = new document.defaultView.Array({}, {});

I believe.

mock_navigator_moz_mobile_connections.js has a similar problem, 

Back to the bluetooth bit, the mock linked to defines it a s a non-configurable property.  But it runs on document-element-inserted, which I'm pretty sure can run multiple times on the same document (e.g. with document.open) and after the first one the redefinition attempts would throw the exception you see.  That shouldn't be related to bholley's patches, though.

In any case, the two failures in the log above are from tests that use mock_navigator_moz_mobile_connections.js and mock_navigator_moz_mobile_connections_multi.js, so start with fixing those mock implementations and see whether that helps?

Comment 7

[Kevin Grandon :kgrandon]

(In reply to Boris Zbarsky [:bz] from comment #6)
> > Could you guys look through the details in comment 3 and 4 and let me know what you
> > think?
> 
> Bobby is on PTO.  I can take a look in more detail on Monday, if needed.
> 
> Are these tests not enabled by default or something?  :(

We're currently working on that, they're hidden by default right now :(

I'll look into seeing if we can update these mocks. Thanks!

Comment 8

[Kevin Grandon :kgrandon]

Attachment: Pull request - update shims to use document.defaultView

Comment 9

[Kevin Grandon :kgrandon]

Let's see what this does on gaia-try.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8499970 [details]
Pull request - update shims to use document.defaultView

Turns out this patch worked!

Hey Arthur or Evelyn - Could you guys help me review this and get this landed? Thanks!

Comment 11

[Evelyn Hung]

Comment on attachment 8499970 [details]
Pull request - update shims to use document.defaultView

I will let Arthur review this since I'm no long daily working in Settings. :)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8499970 [details]
Pull request - update shims to use document.defaultView

r=me based on comment 6.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the patch, Kevin!

master: 33938ee659ea99e6221832e32c8e60122aa34330