1077846 - Scrolling bookmarks changes their font

Status: RESOLVED WORKSFORME

(Core :: Layout: Text and Fonts, defect)

Description

[Mayank Bansal]

Attachment: bookmarks-2014-10-04.json

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141004030203

Steps to reproduce:

1. create a new profile
2. Import the attached bookmarks
3. Open the bookmarks menu
4. Scroll in the bookmark list


Actual results:

The font of the bookmarks changed


Expected results:

not so

Comment 1

[Mayank Bansal]

basically, if you have enough bookmarks to make them scroll, you should see this behaviour

Comment 2

[Alice0775 White]

Attachment: screenshot

Bookmarks text rendered with grayscale anti-aliasing after scroll bookmarks menu and Bookmarks widget dropdowm.

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e620a9b140fa
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140730143007
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1622eb8d6fc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140730150925
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e620a9b140fa&tochange=c1622eb8d6fc



In local build
Last Good:  bb9d2f1e6619 + eed9b58c0ce3+c1622eb8d6fc
First Bad:  80a866643304 + eed9b58c0ce3+c1622eb8d6fc

Regressed by: 
	80a866643304	Robert O'Callahan — Bug 1041530. Be more careful about contributing opaque areas to the window region. r=mattwoodrow

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]: Fount rendering regression since 34

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

Jet - Seems like a bit of an odd bug. Can you please have someone investigate? I'm interested in whether this behaviour will appear anywhere else in the product.

Comment 5

[Jet Villegas (inactive)]

I can't reproduce this bug. I also can't see how the patch applied to fix bug 1041530 would change font rendering.

Comment 6

[Jonathan Kew [:jfkthame]]

(In reply to Jet Villegas (:jet) from comment #5)
> I can't reproduce this bug. I also can't see how the patch applied to fix
> bug 1041530 would change font rendering.

IIUC, we switch between subpixel and grayscale antialiasing depending on whether we're rendering to an opaque background or not; and therefore bug 1041530 does seem to have the potential to change this behavior. I haven't tried to reproduce this on Windows, though, which is where it's most likely to be visible.

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Given that we're at the end of the beta cycle, there hasn't been progress on this bug, and this bug doesn't seem critical enough to fix in 34 at this point in the cycle, I'm marking this as wontfix. I would like to see an investigation to at least understand the source of the issue soon. 

Jet - Where does this bug fit on your priority list? Do you have someone who can investigate while 35 is still on Aurora?

Comment 8

[Jet Villegas (inactive)]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #7)
> Jet - Where does this bug fit on your priority list? 
It's not very high on the list, considering the screenshot attached. Let me know if you see this looking worse elsewhere.

> Do you have someone who can investigate while 35 is still on Aurora?
We can bump up the priority if needed, but bug 1041530 is a fix we'll want to keep in the tree if this is the worst regression.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Given Jet's update in comment 8 I'm removing tracking from this bug.

Comment 10

[Mayank Bansal]

cant reproduce anymore.