1077947 - Localize new www.mozilla.org Get Involved page

Status: VERIFIED FIXED

(www.mozilla.org :: L10N, defect)

Description

[Francesco Lodolo [:flod]]

I realized that we don't have a bug for tracking l10n work on the new Contribute page.

Demo page: https://www-demo3.allizom.org/contribute

Strings have already been extracted and we already have a few locales fully translated.

One file is for the main page
https://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=mozorg/contribute.lang

The other for Stories
https://l10n.mozilla-community.org/~pascalc/langchecker/?locale=all&website=0&file=mozorg/contribute-stories.lang

Comment 1

[Francesco Lodolo [:flod]]

Some l10n issues pointed out so far.

Numbers need to be localized: e.g. "8,722" shouldbe "8.722" in Italian. This involves also the work on the new home page.

Dates for events need to be localize as well. This too involves the new home page.

Sign-up form: text can overlaps the "i" icon. You can see it on the Italian page for "Documentazione"
https://www-demo3.allizom.org/it/contribute/signup/

I'd suggest to move that icon a little above the text (to avoid losing space for localization).

Comment 2

[Théo Chevalier]

On https://www-demo3.allizom.org/contribute/ we need different strings for "country - area" under Mozillians' names, like:

"Spain · Activism"

Currently "Activism" is localized but is reusing string from https://www-demo3.allizom.org/en-US/contribute/signup/

In French for instance it doesn't work, we are using a verb on signup, and we need a noun on contribute :/
Also, country names are not localized at the moment.

Comment 3

[Francesco Lodolo [:flod]]

Country names should be fixed soon server side (they're also used in the list on top).

Not sure how we can fix the name displayed under stories, especially considering that it means adding new strings to all locales. 
We could add a slight changed string for "Activism", "Coding" and "Teaching" to use in the page, and then autotranslate them for complete locales.

Pascal, any though?

P.S. I wouldn't call this "string reusage",

Comment 4

[Francesco Lodolo [:flod]]

One alternative: add 4 more strings in the template for the full bio caption.

Spain - Activism
Philippines - Activism
Switzerland - Coding
India - Teaching

Personally I'm not fond of any of these two options, I think having "sector names" consistent across the page makes sense.

Comment 5

[Pascal Chevrel:pascalc]

I think I don't really like the wording in English:

Rubén
Spain · Activism

Michael
Switzerland · Coding

The title should define the person since we put the strings below their name and picture, so in English it should be:

Rubén
Spain · Activist

Michael
Switzerland · Coder

Although we already have the words for the categories in the file, I don't think there is a consistency problem using a noun with the same root (coding/coder, activism/activist…), especially since they are not visible in the same page (contribute/ vs contribute/signup/).

Maybe we need Matej expertise here, but personnally I would go for adding new strings with nouns. I imagine the reason why French used verbs instead of nouns on the signup page is that verbs are more a call to action than nouns and because in the signup context, we would need to add an article before the noun to sound good (la traduction, l'activisme, le code…) as the category is a continuity of the main title which is an indirect question (what are you interested in?), but if we do add an article, it would be wrong on the bio caption too.

Comment 6

[Francesco Lodolo [:flod]]

If we're going to add new strings, I kind of feel safer with adding the entire sentence.

Spain - Activist
Philippines - Activist
Switzerland - Coder
India - Teacher

That way localizers also have full control on the form and case (and we only move from +3 to +4 strings).

Matej, any thought?

See the caption below Mozillians in this page
https://www-demo3.allizom.org/en-US/contribute/stories/ruben/

Comment 7

[Matej Novak [:matej]]

I'm adding Troy here, who wrote this copy, but here are my thoughts:

I'd actually prefer to keep it as is. The titles are consistent with the way they appear on the signup page. It also subtly changes the meaning to change them. For example, you can contribute to the area of activism without being an activist (which is a much stronger word in English). Or you could be working on l10n tools, which means you're helping with translation, but you're not necessary a translator.

Hopefully that makes sense. Troy, please feel free to weigh in here as well.

Comment 8

[Troy Palmer]

I agree with Matej. Another concern for me would be with the "Helping" category — turning that into a title probably wouldn't communicate what we want it to.

Comment 9

[Francesco Lodolo [:flod]]

OK. We've decided to expose 4 new strings (the entire caption), so localizers will have full control over the string (case, separator, etc.)

Comment 10

[Francesco Lodolo [:flod]]

We really shouldn't be adding new strings to the template without a warning :-\
https://github.com/mozilla/bedrock/commit/12533dafbed292ee713cfac16137e7bea49c1edf#diff-1

"Email format". Can we use only "Format", which is already available in newsletter.lang, so that we don't add a new string 4 days before deadline?

Are there any other strings that I might have missed? I've noticed this one by pure chance (PR on Basket).

Another note: buttons at the bottom of the page (make a donation, download firefox, etc.) have a very weird alignment for some locales
https://www-demo3.allizom.org/it/contribute/

Comment 11

[Craig Cook (:craigcook)]

(In reply to Francesco Lodolo [:flod] from comment #10)
> We really shouldn't be adding new strings to the template without a warning
> :-\
> https://github.com/mozilla/bedrock/commit/
> 12533dafbed292ee713cfac16137e7bea49c1edf#diff-1
> 
> "Email format". Can we use only "Format", which is already available in
> newsletter.lang, so that we don't add a new string 4 days before deadline?

You're right, sorry about that. The format options came up at the last minute and are apparently required (I'd be in favor of defaulting everyone to plain text and not even offering a choice, but it seems some people actually like HTML emails). 

I was trying to avoid a new string but "Format" alone isn't really descriptive enough in this context, but is an adequate fallback. I intended to add the new string behind an l10n tag, but screwed that up in my commit (I pasted the l10n_has_tag piece from elsewhere and neglected to actually edit the tag name). But I've just removed it now and we'll go with "Format" and maybe improve it later.

> Are there any other strings that I might have missed? I've noticed this one
> by pure chance (PR on Basket).

Nothing else has been added. There's "Download Firefox" but that already exists.
 
> Another note: buttons at the bottom of the page (make a donation, download
> firefox, etc.) have a very weird alignment for some locales
> https://www-demo3.allizom.org/it/contribute/

Floats colliding, I thought I had fixed that already but this looks like a regression. I'll fix it again. Thanks!

Comment 12

[Francesco Lodolo [:flod]]

Even if with the old back-end, page is online. Closing.

Comment 13

[Shu-yu Guo [:shu]]

Attachment: Backport for beta

Bug 1108345 is due to this not being in beta.

Comment 14

[Francesco Lodolo [:flod]]

Definitely wrong bug, you might want to attach this to the correct one ;-)

Comment 15

[Shu-yu Guo [:shu]]

Comment on attachment 8535296 [details] [diff] [review]
Backport for beta

Oops, sorry about that.