1077996 - Provide a pref to disable Loop FxA and related items (contacts, direct calling)

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Maire Reavy [:mreavy]]

In case we need to disable FxA/contacts/direct-calling (which really all go together), we need a single-point method of disabling it without having to deal with merges or backouts.  This would also allow us to ship Loop with accountless mode even if account mode has problems.

My preference would be to hide the FxA login (sign in/sign out) -- which would also hide contacts since contacts won't be shown if a user isn't logged in and hide the direct calling feature since direct calls are made form the contacts menu.  We'd also want to make sure we handled logging out anyone who was already logged in when they received the update.  

My thinking is this would not be a user-visible pref, and we'd only have this pref in place for the first couple of releases (for Fx34/Fx35) and remove it later (in the Fx36 timeframe).

This is something we'd want to add as soon as possible.

Comment 1

[Matthew N. [:MattN]]

Attachment: v.1 Allow disabling via loop.fxa.enabled

The pref loop.fxa.enabled set to false can disable these features. The pref requires a restart.

By logging out in initialize, I think this will cover contacts and direct calling.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8500873 [details] [diff] [review]
v.1 Allow disabling via loop.fxa.enabled

Review of attachment 8500873 [details] [diff] [review]:
-----------------------------------------------------------------

Aight, this'll do :)

Thanks!

::: browser/components/loop/test/desktop-local/panel_test.js
@@ +210,5 @@
> +          var view = TestUtils.renderIntoDocument(loop.panel.SettingsDropdown());
> +          expect(view.getDOMNode()).to.be.null;
> +      });
> +
> +

nit: one newline too many

Comment 3

[Matthew N. [:MattN]]

Pushed with the nit fixed: https://hg.mozilla.org/integration/fx-team/rev/1ecd8bc300ba

Thanks

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ecd8bc300ba

Comment 5

[Paul Silaghi, QA [:pauly]]

loop.fxa.enabled hidden pref works fine.
Verified fixed 35.0a1 (2014-10-08) Win 7, Ubuntu 13.04, OS X 10.9.5

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8500873 [details] [diff] [review]
v.1 Allow disabling via loop.fxa.enabled

Approval Request Comment
Part of the staged Loop aurora second uplift set

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/335f5422410a

Comment 8

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 OS X 10.9.5

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8500873 [details] [diff] [review]
v.1 Allow disabling via loop.fxa.enabled

Already landed in aurora, approving for posterity