1078031 - Get rid of RenderMode

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: remove RenderMode

Comment 2

[Robert Longson [:longsonr]]

Attachment: rendermode.txt

Comment 3

[Robert Longson [:longsonr]]

Attachment: rendermode.txt

definitely the right patch this time.

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8500171 [details] [diff] [review]
rendermode.txt

Nice spot!

I would like the "Seems like this is a non-trivial clipPath, so we need to use a clip mask" comment in nsSVGClipPathFrame.cpp to stay though. Actually, expanding it to something like the following would be good I think:

  // This is a non-trivial clipPath, so we need to paint its contents into a
  // temporary surface and use that to mask the clipped content.  Note that
  // nsSVGPathGeometryFrame::Render checks for the NS_STATE_SVG_CLIPPATH_CHILD
  // state bit and paints into our mask surface using opaque black in that case.

Comment 5

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=a1bd9923ed63

Comment 6

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=94e0ef21c3d0

Comment 7

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2003d572d53

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f2003d572d53