Closed
Bug 1078031
Opened 10 years ago
Closed 10 years ago
Get rid of RenderMode
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: longsonr, Assigned: longsonr)
References
Details
Attachments
(1 file, 2 obsolete files)
14.05 KB,
patch
|
jwatt
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → longsonr
Attachment #8500168 -
Flags: review?(jwatt)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8500168 -
Attachment is obsolete: true
Attachment #8500168 -
Flags: review?(jwatt)
Attachment #8500170 -
Flags: review?(jwatt)
Assignee | ||
Comment 3•10 years ago
|
||
definitely the right patch this time.
Attachment #8500170 -
Attachment is obsolete: true
Attachment #8500170 -
Flags: review?(jwatt)
Attachment #8500171 -
Flags: review?(jwatt)
Comment 4•10 years ago
|
||
Comment on attachment 8500171 [details] [diff] [review] rendermode.txt Nice spot! I would like the "Seems like this is a non-trivial clipPath, so we need to use a clip mask" comment in nsSVGClipPathFrame.cpp to stay though. Actually, expanding it to something like the following would be good I think: // This is a non-trivial clipPath, so we need to paint its contents into a // temporary surface and use that to mask the clipped content. Note that // nsSVGPathGeometryFrame::Render checks for the NS_STATE_SVG_CLIPPATH_CHILD // state bit and paints into our mask surface using opaque black in that case.
Attachment #8500171 -
Flags: review?(jwatt) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=a1bd9923ed63
Assignee | ||
Updated•10 years ago
|
Flags: in-testsuite-
Assignee | ||
Comment 6•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=94e0ef21c3d0
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2003d572d53
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f2003d572d53
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•