Closed Bug 1078031 Opened 5 years ago Closed 5 years ago

Get rid of RenderMode

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: longsonr, Assigned: longsonr)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch remove RenderMode (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #8500168 - Flags: review?(jwatt)
Attached patch rendermode.txt (obsolete) — Splinter Review
Attachment #8500168 - Attachment is obsolete: true
Attachment #8500168 - Flags: review?(jwatt)
Attachment #8500170 - Flags: review?(jwatt)
Attached patch rendermode.txtSplinter Review
definitely the right patch this time.
Attachment #8500170 - Attachment is obsolete: true
Attachment #8500170 - Flags: review?(jwatt)
Attachment #8500171 - Flags: review?(jwatt)
Comment on attachment 8500171 [details] [diff] [review]
rendermode.txt

Nice spot!

I would like the "Seems like this is a non-trivial clipPath, so we need to use a clip mask" comment in nsSVGClipPathFrame.cpp to stay though. Actually, expanding it to something like the following would be good I think:

  // This is a non-trivial clipPath, so we need to paint its contents into a
  // temporary surface and use that to mask the clipped content.  Note that
  // nsSVGPathGeometryFrame::Render checks for the NS_STATE_SVG_CLIPPATH_CHILD
  // state bit and paints into our mask surface using opaque black in that case.
Attachment #8500171 - Flags: review?(jwatt) → review+
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/f2003d572d53
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Depends on: 1130888
Depends on: 1370116
You need to log in before you can comment on or make changes to this bug.