1078182 - crash in java.lang.NullPointerException: at org.mozilla.search.SearchWidget.addView(SearchWidget.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Flaviu Cos]

This bug was filed from the Socorro interface and is 
report bp-a9a85a7c-8e4f-4377-bc37-c30de2141006.
=============================================================
Environment: 
Device: Samsung Galaxy R (Android 2.3.4);
Build: Nightly 35.0a1 (2014-10-06);

Steps to reproduce:
1. Launch Search Activity from the widget.

Expected result:
Search Activity is successfully launched.

Actual result:
Firefox crashes.

Notes:
Only reproducible on gingerbread devices.

Stack trace:

java.lang.NullPointerException
	at org.mozilla.search.SearchWidget.addView(SearchWidget.java:109)
	at org.mozilla.search.SearchWidget.onUpdate(SearchWidget.java:46)
	at android.appwidget.AppWidgetProvider.onReceive(AppWidgetProvider.java:61)
	at org.mozilla.search.SearchWidget.onReceive(SearchWidget.java:104)
	at android.app.ActivityThread.handleReceiver(ActivityThread.java:1798)
	at android.app.ActivityThread.access$2400(ActivityThread.java:117)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:985)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3691)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:907)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:665)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[:Margaret Leibovic]

wesj, can you look into this?

Comment 2

[Aaron Train [:aaronmt]]

Is this a regression?

Comment 3

[:Margaret Leibovic]

It looks like this will happen if options is null here:
http://hg.mozilla.org/mozilla-central/annotate/25a98bac9264/mobile/android/search/java/org/mozilla/search/SearchWidget.java#l109

This was added in bug 815682.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8501962 [details] [diff] [review]
Patch

I don't have a GB device to test this on anymore.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8501962 [details] [diff] [review]
Patch

Review of attachment 8501962 [details] [diff] [review]:
-----------------------------------------------------------------

I also don't have a GB device with me, but this sounds reasonable. Let's get a build to QA to test.

Comment 7

[Aaron Train [:aaronmt]]

CC'ing Flaviu. If you have a build, he can test it.

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/ef347007fb04

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ef347007fb04

Comment 10

[Flaviu Cos]

Verified as fixed in build 36.0a1 (2014-10-17);
Device: Samsung Galaxy R (Android 2.3.4).

Comment 11

[u279076]

I'm seeing 3 crashes with this signature for Fennec 35.0a2. Do we want to fix this there too?

Comment 12

[:Margaret Leibovic]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #11)
> I'm seeing 3 crashes with this signature for Fennec 35.0a2. Do we want to
> fix this there too?

Yes, this is tracking 35, we should uplift this.

Comment 13

[Wesley Johnston (:wesj)]

Comment on attachment 8501962 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1035642
[User impact if declined]: Crash on some devices when using the widget
[Describe test coverage new/current, TBPL]: No widget testing available.
[Risks and why]: Low risk. Basically a null check.
[String/UUID change made/needed]: None.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b8131990bbb6

Comment 15

[Flaviu Cos]

Aurora stops unexpectedly when trying to launch Search Activity from the widget.
After that there is no visible action when tapping on any button from Search Activity widget.

Aurora also stops unexpectedly right after device is turned on.

Comment 16

[Flaviu Cos]

Verified as fixed in build 35 beta 1.
Device: Samsung Galaxy R (Android 2.3.4).