Closed
Bug 1078182
Opened 10 years ago
Closed 10 years ago
crash in java.lang.NullPointerException: at org.mozilla.search.SearchWidget.addView(SearchWidget.java)
Categories
(Firefox for Android Graveyard :: Search Activity, defect)
Tracking
(firefox35 verified, firefox36 verified, fennec35+)
VERIFIED
FIXED
Firefox 36
People
(Reporter: cos_flaviu, Assigned: wesj)
References
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
2.46 KB,
patch
|
Margaret
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-a9a85a7c-8e4f-4377-bc37-c30de2141006. ============================================================= Environment: Device: Samsung Galaxy R (Android 2.3.4); Build: Nightly 35.0a1 (2014-10-06); Steps to reproduce: 1. Launch Search Activity from the widget. Expected result: Search Activity is successfully launched. Actual result: Firefox crashes. Notes: Only reproducible on gingerbread devices. Stack trace: java.lang.NullPointerException at org.mozilla.search.SearchWidget.addView(SearchWidget.java:109) at org.mozilla.search.SearchWidget.onUpdate(SearchWidget.java:46) at android.appwidget.AppWidgetProvider.onReceive(AppWidgetProvider.java:61) at org.mozilla.search.SearchWidget.onReceive(SearchWidget.java:104) at android.app.ActivityThread.handleReceiver(ActivityThread.java:1798) at android.app.ActivityThread.access$2400(ActivityThread.java:117) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:985) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:130) at android.app.ActivityThread.main(ActivityThread.java:3691) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:507) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:907) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:665) at dalvik.system.NativeStart.main(Native Method)
Comment 1•10 years ago
|
||
wesj, can you look into this?
tracking-fennec: --- → ?
Flags: needinfo?(wjohnston)
Comment 2•10 years ago
|
||
Is this a regression?
Comment 3•10 years ago
|
||
It looks like this will happen if options is null here: http://hg.mozilla.org/mozilla-central/annotate/25a98bac9264/mobile/android/search/java/org/mozilla/search/SearchWidget.java#l109 This was added in bug 815682.
Blocks: fennec-lockscreen
Assignee | ||
Comment 4•10 years ago
|
||
Flags: needinfo?(wjohnston)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8501962 [details] [diff] [review] Patch I don't have a GB device to test this on anymore.
Attachment #8501962 -
Attachment description: widget1 → Patch
Attachment #8501962 -
Attachment is patch: true
Attachment #8501962 -
Flags: review?(margaret.leibovic)
Comment 6•10 years ago
|
||
Comment on attachment 8501962 [details] [diff] [review] Patch Review of attachment 8501962 [details] [diff] [review]: ----------------------------------------------------------------- I also don't have a GB device with me, but this sounds reasonable. Let's get a build to QA to test.
Attachment #8501962 -
Flags: review?(margaret.leibovic) → review+
Updated•10 years ago
|
tracking-fennec: ? → 35+
Comment 7•10 years ago
|
||
CC'ing Flaviu. If you have a build, he can test it.
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ef347007fb04
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ef347007fb04
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
Target Milestone: Firefox 35 → Firefox 36
Reporter | ||
Comment 10•10 years ago
|
||
Verified as fixed in build 36.0a1 (2014-10-17); Device: Samsung Galaxy R (Android 2.3.4).
status-firefox36:
--- → verified
Comment 11•10 years ago
|
||
I'm seeing 3 crashes with this signature for Fennec 35.0a2. Do we want to fix this there too?
Comment 12•10 years ago
|
||
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #11) > I'm seeing 3 crashes with this signature for Fennec 35.0a2. Do we want to > fix this there too? Yes, this is tracking 35, we should uplift this.
Flags: needinfo?(wjohnston)
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8501962 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: bug 1035642 [User impact if declined]: Crash on some devices when using the widget [Describe test coverage new/current, TBPL]: No widget testing available. [Risks and why]: Low risk. Basically a null check. [String/UUID change made/needed]: None.
Flags: needinfo?(wjohnston)
Attachment #8501962 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8501962 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 15•10 years ago
|
||
Aurora stops unexpectedly when trying to launch Search Activity from the widget. After that there is no visible action when tapping on any button from Search Activity widget. Aurora also stops unexpectedly right after device is turned on.
Reporter | ||
Comment 16•9 years ago
|
||
Verified as fixed in build 35 beta 1. Device: Samsung Galaxy R (Android 2.3.4).
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•