1078208 - [Loop] Changing the device language, don't change the loop app language

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Tested with Flame KK v180, Gecko-675810c.Gaia-092d2b7 and Loop v. d159db7

STR
1. Open Loop app and log-in into loop
2. Go to settings (device settings, not loop settings) and change the language (i.e from English to Spanish)
3. With the task switch go to loop app again

ACTUAL RESULT
The loop app language don't change. In order to refresh the language you have to kill the app and open it again

EXPECTED RESULT
The app language should change without killing the app

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Addressing this review to Carmen (although she is a new member of this team like me) because the code is not related to Loop and we can help Borja, Fernando or J.Antonio here without stealing their time

Comment 2

[Carmen Jimenez Cabezas]

Comment on attachment 8501575 [details]
Github pull request

Good work, thanks. r+ from my side

Comment 3

[Cristian Rodriguez (:crdlc)]

in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c8702e223d9ad0636585da547743debf9da0f5fe

Comment 4

[Javier de Prado]

In logout screen, text "you are logged in as...." or "Conectado como...", doesn't change.
See attachments.

Comment 5

[Javier de Prado]

Attachment: 2014-10-09-15-26-59.png

Text "Conectado como" doesn't change

Comment 6

[Javier de Prado]

Attachment: 2014-10-09-15-28-22.png

Text "Conectado como" doesn't change

Comment 7

[Maria Angeles Oteo (:oteo)]

Javier this bug has already been reported (bug 1080356)
so resolving it again, thanks a lot!!

Comment 8

[Javier de Prado]

Sorry... I've tested again in b513867 and it runs fine. Sorry!
Verified!