Closed
Bug 1078231
Opened 11 years ago
Closed 11 years ago
Enhance Favicon display in RecentTabs list for closed ReaderMode pages
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: capella, Assigned: capella)
Details
Attachments
(1 file)
|
2.22 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
After swiping closed a Tab that's displayed in ReaderMode, it's TwoLinePageRow view properly displays 'about:reader?url=foo' ... as the closed URL ... tapping the view item allows us to navigate back to the page in ReaderMode.
However, the URL as passed to Favicons contains that prefix bit, causing us to load and display a generic icon.
This small patch recognizes this, and passes the correct URL to Favicons so we can better determine and display its Favicon.
Attachment #8500380 -
Flags: review?(margaret.leibovic)
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8500380 [details] [diff] [review]
bugRecentTabsFavicon.diff
Review of attachment 8500380 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch.
Attachment #8500380 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Been trying to tidy up Favicons-based edge cases where the UI could be improved
:-D
https://tbpl.mozilla.org/?tree=Try&rev=e45371aaee88
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•