Closed Bug 1078231 Opened 5 years ago Closed 5 years ago

Enhance Favicon display in RecentTabs list for closed ReaderMode pages

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: capella, Assigned: capella)

Details

Attachments

(1 file)

After swiping closed a Tab that's displayed in ReaderMode, it's TwoLinePageRow view properly displays 'about:reader?url=foo' ... as the closed URL ... tapping the view item allows us to navigate back to the page in ReaderMode.

However, the URL as passed to Favicons contains that prefix bit, causing us to load and display a generic icon.

This small patch recognizes this, and passes the correct URL to Favicons so we can better determine and display its Favicon.
Attachment #8500380 - Flags: review?(margaret.leibovic)
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment on attachment 8500380 [details] [diff] [review]
bugRecentTabsFavicon.diff

Review of attachment 8500380 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.
Attachment #8500380 - Flags: review?(margaret.leibovic) → review+
Been trying to tidy up Favicons-based edge cases where the UI could be improved
:-D

https://tbpl.mozilla.org/?tree=Try&rev=e45371aaee88
https://hg.mozilla.org/mozilla-central/rev/c5c3dbaf007e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.