Closed Bug 1078247 Opened 5 years ago Closed 5 years ago

[v2.2] Fix keyboard object app after updates from Bug 996332

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RobertC, Assigned: RobertC)

Details

Attachments

(1 file)

Test started failing because the keyboard app behavior was updated in the following commit:
https://github.com/mozilla-b2g/gaia/commit/f00b5919694214bef4309a3aa5f65e997a2960f5

After tapping on the "@" character the keyboard switches back to the alpha display.
The keyboard page object need to be updated.
It looks like there is a race condition between the automated layout switching (which occurs when tapping @) and the following code:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/keyboard/app.py#L102

When the test fails, the code mentioned above returns the layout status as the one from before the automated switch. I added a time.sleep(1) before that and the test passes 5 out of 5.
I will try to find a proper wait() for this issue.
Attachment #8500928 - Flags: review?(viorela.ioia)
Attachment #8500928 - Flags: review?(florin.strugariu)
Comment on attachment 8500928 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24879

r+
Attachment #8500928 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8500928 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24879

If we add the comment explaining why did we add that wait
Attachment #8500928 - Flags: review?(florin.strugariu) → review+
QA Whiteboard: [fxosqa-auto-s1]
You need to log in before you can comment on or make changes to this bug.