1078261 - Authentication error in the Loop panel on 1:1 calls

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Paul Silaghi, QA [:pauly]]

Attachment: loop authentication error.png

STR:
1. Start a call between 2 FF profiles
2. Open the Loop panel on the callee side

Actual results:
authentication error

Last good revision: b85c260821ab (2014-10-03)
First bad revision: 229801d17f7e (2014-10-04)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b85c260821ab&tochange=229801d17f7e

Comment 1

[Paul Silaghi, QA [:pauly]]

Last good revision: 60e90dd7f64f
First bad revision: 7a45d556f280
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=60e90dd7f64f&tochange=7a45d556f280

Comment 2

[Mark Banner (:standard8)]

Probably from bug 1047164

Comment 3

[Nils Ohlmeier [:drno]]

Probably worth nothing that at least for me this happened without being logged in to any FireFox Account. So the red icon is probably correct/expected if the user is using an FF Account. But if no account is being used, this error message should be suppressed.

Comment 4

[Maire Reavy [:mreavy]]

FYI: This isn't happening to me.  I started out not logged in (no red bubble) and then logged in with no problems (no red bubble).  NOTE: I had logged in prior to today, and Nils had not.  To repro, you may need to use a fresh profile -- or not have logged into FxA before.

Comment 5

[Matthew N. [:MattN]]

Attachment: v.1 Don't fetch Loop call data for the FxA session if we aren't logged in

We were trying to fetch FxA call data even if we aren't logged in.

Comment 6

[Matthew N. [:MattN]]

Thanks.

https://hg.mozilla.org/integration/fx-team/rev/805fa09191ab

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8500697 [details] [diff] [review]
v.1 Don't fetch Loop call data for the FxA session if we aren't logged in

Approval Request Comment
[Feature/regressing bug #]: bug 1047164 and bug 1065155
[User impact if declined]: Once bug 1047164 gets uplifted users would see an authentication error bar upon receiving a call as a guest.
[Describe test coverage new/current, TBPL]: xpcshell test and manual test by me. The problem was obvious and has a simple fix.
[Risks and why]: Low risk straightforward fix.
[String/UUID change made/needed]: None.

Comment 8

[Maire Reavy [:mreavy]]

FYI:  This will be part of the second uplift to Aurora that I am planning for this Thursday.  

For Sheriffs or anyone doing Aurora uplifts -- Please ping me (mreavy on irc) before doing any Loop bug uplifts to Aurora.  Thanks.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/805fa09191ab

Comment 10

[u279076]

(In reply to Carsten Book [:Tomcat] from comment #9)
> https://hg.mozilla.org/mozilla-central/rev/805fa09191ab

Paul, please verify this is fixed in tomorrow's Nightly.

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed 35.0a1 (2014-10-08) Win 7, Ubuntu 13.04, OS X 10.9.5

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/df4f2ead09fb

Comment 13

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 OS X 10.9.5, Win 7

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8500697 [details] [diff] [review]
v.1 Don't fetch Loop call data for the FxA session if we aren't logged in

Post landed approval (already landed)

Comment 15

[u279076]

Does this regression have Engineering test coverage?

Comment 16

[Mark Banner (:standard8)]

Clearing in-testsuite requests for features that are being removed from Hello as part of te user journey work in bug 1209713.